opendatahub-io / opendatahub-operator

Open Data Hub operator to manage ODH component integrations
https://opendatahub.io
Apache License 2.0
59 stars 128 forks source link

chore: change local "manifests" folder to match in-image path #1143

Closed zdtsw closed 1 month ago

zdtsw commented 1 month ago

Description

How Has This Been Tested?

>make clean removed opt/manifests folder >make get-manifests downloaded components manifests into $(pwd)/opt/manifests

local build: quay.io/wenzhou/opendatahub-operator-catalog:v2.15.7-29 create DSCI and DSC CR check pods in application NS >oc get pod -n opendatahub NAME READY STATUS RESTARTS AGE codeflare-operator-manager-5bb9f6745c-7mhv9 1/1 Running 0 2m1s data-science-pipelines-operator-controller-manager-79468c977tct 1/1 Running 0 2m43s etcd-5cd44cd8dd-hbrrn 1/1 Running 0 2m45s kserve-controller-manager-5766998974-qmh69 1/1 Running 0 2m6s kuberay-operator-99c646567-4w2zv 1/1 Running 0 114s kueue-controller-manager-54556ffb7f-l2rlq 1/1 Running 0 2m2s modelmesh-controller-b7897bb45-q8vgw 1/1 Running 0 2m45s modelmesh-controller-b7897bb45-s7p6d 1/1 Running 0 2m45s modelmesh-controller-b7897bb45-sv2f6 1/1 Running 0 2m45s notebook-controller-deployment-8554657d6d-5gd75 1/1 Running 0 2m49s odh-dashboard-76c49655cf-5hx99 2/2 Running 0 2m51s odh-dashboard-76c49655cf-hg9mk 2/2 Running 0 2m51s odh-model-controller-57b9ffbdfc-99q7m 1/1 Running 0 2m44s odh-model-controller-57b9ffbdfc-xlk7p 1/1 Running 0 2m44s odh-model-controller-57b9ffbdfc-z5ndw 1/1 Running 0 2m44s odh-notebook-controller-manager-7cf9954577-6jh7h 1/1 Running 0 2m51s trustyai-service-operator-controller-manager-6f7bff965f-l6szm 1/1 Running 0 113s

Screenshot or short clip

Merge criteria

lburgazzoli commented 1 month ago

I guess get_all_manifests.sh should be amended as well

lburgazzoli commented 1 month ago

I guess get_all_manifests.sh should be amended as well

never mind, missed the changes in the github diff for some reason

openshift-ci[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lburgazzoli

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/opendatahub-io/opendatahub-operator/blob/incubation/OWNERS)~~ [lburgazzoli] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment