opendatahub-io / opendatahub-operator

Open Data Hub operator to manage ODH component integrations
https://opendatahub.io
Apache License 2.0
59 stars 128 forks source link

fix: for Managed cluster, we need another namespace or it will be deteced as self-managed #1146

Closed zdtsw closed 1 month ago

zdtsw commented 1 month ago

During testing, we found out the Managed has Catsrc installed into a different cluster.

Description

https://issues.redhat.com/browse/RHOAIENG-10678

How Has This Been Tested?

Screenshot or short clip

Merge criteria

zdtsw commented 1 month ago

@bdattoma FYI

openshift-ci[bot] commented 1 month ago

@bdattoma: changing LGTM is restricted to collaborators

In response to [this](https://github.com/opendatahub-io/opendatahub-operator/pull/1146#pullrequestreview-2208132972): > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
openshift-ci[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: asanzgom, bdattoma, ykaliuta

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/opendatahub-io/opendatahub-operator/blob/incubation/OWNERS)~~ [asanzgom,ykaliuta] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
zdtsw commented 1 month ago

/retest