doc: correct godoc - Githubissues

opendatahub-io / opendatahub-operator

Open Data Hub operator to manage ODH component integrations

https://opendatahub.io

Apache License 2.0

60 stars 139 forks source link

doc: correct godoc #1152

Closed zdtsw closed 2 months ago

zdtsw commented 2 months ago

Description

to follow up discussion https://github.com/opendatahub-io/opendatahub-operator/pull/1145#discussion_r1700136942 By reading upgrade document, my understanding is, the code logic is correct but the comments did not get updated.

How Has This Been Tested?

Screenshot or short clip

Merge criteria

[ ] You have read the contributors guide.
[ ] Commit messages are meaningful - have a clear and concise summary and detailed explanation of what was changed and why.
[ ] Pull Request contains a description of the solution, a link to the JIRA issue, and to any dependent or related Pull Request.
[ ] Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
[ ] The developer has manually tested the changes and verified that the changes work

ykaliuta commented 2 months ago

It will make conflict in #1145 I added removing of the line there

zdtsw commented 2 months ago

It will make conflict in #1145 I added removing of the line there

i can make this as a draft , just need @VaishnaviHire to double confirm it is the right logic, then i can close this PR or you can cherry pick it to 1145 if you want.

ykaliuta commented 2 months ago

It will make conflict in #1145 I added removing of the line there

i can make this as a draft , just need @VaishnaviHire to double confirm it is the right logic, then i can close this PR or you can cherry pick it to 1145 if you want.

Let me remove it from #1145 then. It is been outdated for a while already and is not related directly to the PR

openshift-ci[bot] commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: VaishnaviHire

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/opendatahub-io/opendatahub-operator/blob/incubation/OWNERS)~~ [VaishnaviHire] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment