[RHOAIENG-10647] - Configure Knative PVC support as default

opendatahub-io / opendatahub-operator

Open Data Hub operator to manage ODH component integrations

https://opendatahub.io

Apache License 2.0

59 stars 128 forks source link

[RHOAIENG-10647] - Configure Knative PVC support as default #1154

Closed spolti closed 1 month ago

spolti commented 1 month ago

chore: Enable by default the serving features to allow pvc mounts.

Description

How Has This Been Tested?

Screenshot or short clip

Merge criteria

[ ] You have read the contributors guide.
[ ] Commit messages are meaningful - have a clear and concise summary and detailed explanation of what was changed and why.
[ ] Pull Request contains a description of the solution, a link to the JIRA issue, and to any dependent or related Pull Request.
[ ] Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
[ ] The developer has manually tested the changes and verified that the changes work

danielezonca commented 1 month ago

As far as I can read in the original ticket, one of the requirement is "These flags should be enabled by default only if the knative-serving resource is owned by us, it can be check in the OperatorHub, in the KnativeService resource" But the PR seems not including this. @spolti Am I missing something?

Other comment, what is the migration strategy for existing cluster? None (aka release note and documentation)?

Make sure to get review from Serverless team too

spolti commented 1 month ago

@danielezonca these checks are done by the opendatahub-operator already.

There is no migration plan for existing ones, it only applies to new installs.

About the serverless team, we have asked their thoughts in the assessment doc we've started before proposing this conf as default.

spolti commented 1 month ago

@israel-hdez hi, since Jooho is on PTO, do you mind reviewing it?

openshift-ci[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: israel-hdez Once this PR has been reviewed and has the lgtm label, please assign etirelli for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/opendatahub-io/opendatahub-operator/blob/incubation/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment