fix(feature): ensures all new resources are created in one reconcile

bartoszmajsak commented 2 months ago

Description

Manifests used by Feature to create cluster resources can be either defined as a single resource per file or grouped together and separated using the --- delimiter. Even though the former approach is currently preferred across the codebase, the latter is used to create Envoy filters for the KServe setup.

When applying resources not yet present in the cluster, the original implementation returns after creating the first resource, leaving the rest unprocessed. They are applied in the next reconcile loop, though again on a one-per-reconcile event basis. This is not a bug per se, as it will eventually result in creating all resources; however, it is suboptimal.

This change ensures all resources defined in a single YAML manifest, separated using ---, are processed in a single go.

How Has This Been Tested?

Enhanced integration test, which, when executed without this patch, fails due to described issue.

Screenshot or short clip

Merge criteria

[x] You have read the contributors guide.
[x] Commit messages are meaningful - have a clear and concise summary and detailed explanation of what was changed and why.
[x] Pull Request contains a description of the solution, a link to the JIRA issue, and to any dependent or related Pull Request.
[x] Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
[x] The developer has manually tested the changes and verified that the changes work

openshift-ci[bot] commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ykaliuta, zdtsw

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/opendatahub-io/opendatahub-operator/blob/incubation/OWNERS)~~ [ykaliuta,zdtsw] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

bartoszmajsak commented 2 months ago

@zdtsw prow is borked?

zdtsw commented 2 months ago

@zdtsw prow is borked?

seems so, lets get it a rest and try again later today

bartoszmajsak commented 2 months ago

/retest

israel-hdez commented 2 months ago

@zdtsw a review was needed from me?

zdtsw commented 2 months ago

More on the reference side @israel-hdez since it is related to kserve

opendatahub-io / opendatahub-operator