feat: add predicates on deployment - Githubissues

opendatahub-io / opendatahub-operator

Open Data Hub operator to manage ODH component integrations

https://opendatahub.io

Apache License 2.0

60 stars 139 forks source link

feat: add predicates on deployment #1172

Closed zdtsw closed 2 months ago

zdtsw commented 2 months ago

Description

~~rename updateResoruce() to CreateOrUpdateResource()~~ ~~use annoataion RHOAIApplicationNamespace and ODHApplicationNamespace than hardcode~~

add predicate.Funcs for deployments to reduce reconciles on all components ~~use switch for better readiness in CreateOrUpdateResource for annotation handling~~

How Has This Been Tested?

local build: quay.io/wenzhou/opendatahub-operator-catalog:v2.13.11024-1

create default dsc in a new opendatahub namespace
manually delete component deployment, it got reconciled
update component replica/resource, it got remained
remove kserve and create again with rawdeployment
check inference CM is still able to set domainname with annotation

Screenshot or short clip

Merge criteria

[ ] You have read the contributors guide.
[ ] Commit messages are meaningful - have a clear and concise summary and detailed explanation of what was changed and why.
[ ] Pull Request contains a description of the solution, a link to the JIRA issue, and to any dependent or related Pull Request.
[ ] Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
[ ] The developer has manually tested the changes and verified that the changes work

openshift-ci[bot] commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ykaliuta

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/opendatahub-io/opendatahub-operator/blob/incubation/OWNERS)~~ [ykaliuta] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment