feat(make): adds generate to default targets

bartoszmajsak commented 2 months ago

Description

The current list of default targets includes manifests which generates CRDs based on API code changes. Still, it does not invoke generate which is responsible for generating additional code (namely DeepCopy funcs).

This can result in incomplete implementation where CRDs reflect the latest changes in the API, but internally it might not be possible to use due to missing copy methods or even outdated implementations of those that already exist.

This change adds it to the list of default targets so that each code change can be committed with the complete set of changes for controller-runtime.

How Has This Been Tested?

Screenshot or short clip

Merge criteria

[x] You have read the contributors guide.
[x] Commit messages are meaningful - have a clear and concise summary and detailed explanation of what was changed and why.
[x] Pull Request contains a description of the solution, a link to the JIRA issue, and to any dependent or related Pull Request.
[x] Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
[x] The developer has manually tested the changes and verified that the changes work

bartoszmajsak commented 2 months ago

Alternatively we can combine both to one generate target.

openshift-ci[bot] commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zdtsw

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/opendatahub-io/opendatahub-operator/blob/incubation/OWNERS)~~ [zdtsw] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

opendatahub-io / opendatahub-operator