opendatahub-io / opendatahub-operator

Open Data Hub operator to manage ODH component integrations
https://opendatahub.io
Apache License 2.0
60 stars 139 forks source link

chore: replace usage of fmt.Printf with logger #1201

Closed lburgazzoli closed 2 months ago

lburgazzoli commented 2 months ago

Description

How Has This Been Tested?

Screenshot or short clip

Merge criteria

zdtsw commented 2 months ago

/onhold just wait for you two to finalze discussion

bartoszmajsak commented 2 months ago

@lburgazzoli I was wondering the other day if carrying the logger through ctx would be a good approach long-term. WDYT?

lburgazzoli commented 2 months ago

@lburgazzoli I was wondering the other day if carrying the logger through ctx would be a good approach long-term. WDYT?

In the go community there are different opinion on the topic, but I think it makes sense. However, I would look into it (eventually) in a separate PR as it probably require some more intrusive changes.

lburgazzoli commented 2 months ago

/restest

openshift-ci[bot] commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ykaliuta, zdtsw

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/opendatahub-io/opendatahub-operator/blob/incubation/OWNERS)~~ [ykaliuta,zdtsw] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
lburgazzoli commented 2 months ago

/test opendatahub-operator-e2e

lburgazzoli commented 2 months ago

/retest