Closed lburgazzoli closed 2 months ago
/onhold just wait for you two to finalze discussion
@lburgazzoli I was wondering the other day if carrying the logger through ctx
would be a good approach long-term. WDYT?
@lburgazzoli I was wondering the other day if carrying the logger through
ctx
would be a good approach long-term. WDYT?
In the go community there are different opinion on the topic, but I think it makes sense. However, I would look into it (eventually) in a separate PR as it probably require some more intrusive changes.
/restest
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: ykaliuta, zdtsw
The full list of commands accepted by this bot can be found here.
The pull request process is described here
/test opendatahub-operator-e2e
/retest
Description
How Has This Been Tested?
Screenshot or short clip
Merge criteria
Pull Request contains a description of the solution, a link to the JIRA issue, and to any dependent or related Pull Request.Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).The developer has manually tested the changes and verified that the changes work