feat: set DSCI application namespace to be immutable

zdtsw commented 2 months ago

put on-hold label for now , just waiting for reviewers all agree on this change

Description

we do not support other values for now, this is to prevent user change to different value and cause old and new both running
till we have a good solution to support this configable filed it is better to make it fixed value instead of dealing with post-fix when user change to another namespace after default one has been used.

How Has This Been Tested?

local build: quay.io/wenzhou/opendatahub-operator-catalog:v2.18.112

instnall operator
create default DSCI CR with opendatahub as applicationNamespace
change applicatoinNamspace from opendatahub to opendatahub2, got error "Error "Invalid value: "string": ApplicationsNamespace is immutable" for field "spec.applicationsNamespace"."
delete DSCI CR
create another DSCI CR but with opendatahub3 as applicationNamespace
check opendatahub3 namespace created
change applicationNamespace from opendatahub3 to opendatahub4 in DSCI, got error "Error "Invalid value: "string": ApplicationsNamespace is immutable" for field "spec.applicationsNamespace"."

Screenshot or short clip

Merge criteria

[ ] You have read the contributors guide.
[ ] Commit messages are meaningful - have a clear and concise summary and detailed explanation of what was changed and why.
[ ] Pull Request contains a description of the solution, a link to the JIRA issue, and to any dependent or related Pull Request.
[ ] Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
[ ] The developer has manually tested the changes and verified that the changes work

openshift-ci[bot] commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lburgazzoli

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/opendatahub-io/opendatahub-operator/blob/incubation/OWNERS)~~ [lburgazzoli] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

VaishnaviHire commented 1 month ago

A user running odh installation where they create dsci should be able to configure applicationNamespace. Are there any component failures that we see when the namespace value is different?

zdtsw commented 1 month ago

A user running odh installation where they create dsci should be able to configure applicationNamespace. Are there any component failures that we see when the namespace value is different?

this is mainly coming from https://github.com/opendatahub-io/opendatahub-operator/issues/455#issuecomment-1725574970 we never resolve this problem properly. the case is: when user first create DSCI with default application value opendatahub, it works, but later if change value to e.g new-opendatahub, it deploys everything to the new-opendatahub NS, but leave the old resources running in opendatahub NS. this is the same for both application and monitoring namespace.

in the case if user running in ODH, the auto creation of DSCI is disabled by default, users re responsible to which namespace they want to use as application namespace. so the value can be set during creation. this allows a different namespace than opendatahub to start with. the only thing is, afterwards they cannot change namespace via the same DSCI CR.

VaishnaviHire commented 1 month ago

/hold cancel

opendatahub-io / opendatahub-operator