opendatahub-io / opendatahub-operator

Open Data Hub operator to manage ODH component integrations
https://opendatahub.io
Apache License 2.0
60 stars 139 forks source link

feat: add support for Ray #1315

Closed zdtsw closed 4 days ago

zdtsw commented 1 week ago

Description

https://issues.redhat.com/browse/RHOAIENG-13182

How Has This Been Tested?

local build: quay.io/wenzhou/opendatahub-operator-catalog:v2.16.13182-3


- update DSC to set Ray to Removed
- check ray CR again, it is gone
- check ray pod again, it is gone too
- check DSC

installedComponents: dashboard: true ray: false phase: Ready



## Screenshot or short clip
<!--- If applicable, attach a screenshot or a short clip demonstrating the feature. -->

## Merge criteria
<!--- This PR will be merged by any repository approver when it meets all the points in the checklist -->
<!--- Go over all the following points, and put an `x` in all the boxes that apply. -->

- [ ] You have read the [contributors guide](https://github.com/opendatahub-io/opendatahub-operator/blob/incubation/CONTRIBUTING.md).
- [ ] Commit messages are meaningful - have a clear and concise summary and detailed explanation of what was changed and why.
- [ ] Pull Request contains a description of the solution, a link to the JIRA issue, and to any dependent or related Pull Request.
- [ ] Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
- [ ] The developer has manually tested the changes and verified that the changes work
openshift-ci[bot] commented 1 week ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please ask for approval from zdtsw. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/opendatahub-io/opendatahub-operator/blob/feature-operator-refactor/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
codecov[bot] commented 1 week ago

Codecov Report

Attention: Patch coverage is 0% with 22 lines in your changes missing coverage. Please review.

Please upload report for BASE (feature-operator-refactor@7d4613c). Learn more about missing BASE report.

Files with missing lines Patch % Lines
...atasciencecluster/datasciencecluster_controller.go 0.00% 22 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## feature-operator-refactor #1315 +/- ## ============================================================ Coverage ? 24.54% ============================================================ Files ? 52 Lines ? 4273 Branches ? 0 ============================================================ Hits ? 1049 Misses ? 3095 Partials ? 129 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

lburgazzoli commented 4 days ago

LGTM