feat: watch Ingress CR updates

opendatahub-io / opendatahub-operator

Open Data Hub operator to manage ODH component integrations

https://opendatahub.io

Apache License 2.0

60 stars 139 forks source link

feat: watch Ingress CR updates #1319

Open zdtsw opened 1 week ago

zdtsw commented 1 week ago

Description

if user set appsDomain, we need to trigger changes to reflect it

only on update event
only check cluster CR
set in cache move ingresscontroller to watch than own it

How Has This Been Tested?

Screenshot or short clip

Merge criteria

[ ] You have read the contributors guide.
[ ] Commit messages are meaningful - have a clear and concise summary and detailed explanation of what was changed and why.
[ ] Pull Request contains a description of the solution, a link to the JIRA issue, and to any dependent or related Pull Request.
[ ] Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
[ ] The developer has manually tested the changes and verified that the changes work

openshift-ci[bot] commented 1 week ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please ask for approval from zdtsw. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/opendatahub-io/opendatahub-operator/blob/incubation/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

zdtsw commented 1 week ago

/retest-required

codecov[bot] commented 1 week ago

Codecov Report

Attention: Patch coverage is 0% with 14 lines in your changes missing coverage. Please review.

Please upload report for BASE (incubation@8ea9ea0). Learn more about missing BASE report.

Files with missing lines	Patch %	Lines
...atasciencecluster/datasciencecluster_controller.go	0.00%	14 Missing :warning:

Additional details and impacted files

```diff @@ Coverage Diff @@ ## incubation #1319 +/- ## ============================================= Coverage ? 19.01% ============================================= Files ? 30 Lines ? 3382 Branches ? 0 ============================================= Hits ? 643 Misses ? 2670 Partials ? 69 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.