Reduce log verbosity for the gc service

opendatahub-io / opendatahub-operator

Open Data Hub operator to manage ODH component integrations

https://opendatahub.io

Apache License 2.0

62 stars 144 forks source link

Reduce log verbosity for the gc service #1392

Closed lburgazzoli closed 5 days ago

lburgazzoli commented 5 days ago

If the GC service is not authorixed to list some particular types, it emits a message "cannot list resource" that may be misleading as it does not impact the behavior of the GC service. This commit set the log verbosity to 3 so it is not shown by default, but can be enabled eventually for troubleshooting

Description

How Has This Been Tested?

Screenshot or short clip

Merge criteria

[x] You have read the contributors guide.
[x] Commit messages are meaningful - have a clear and concise summary and detailed explanation of what was changed and why.
[x] Pull Request contains a description of the solution, a link to the JIRA issue, and to any dependent or related Pull Request.
[ ] ~~Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).~~
[x] The developer has manually tested the changes and verified that the changes work

lburgazzoli commented 5 days ago

Relates to https://github.com/opendatahub-io/opendatahub-operator/pull/1391

openshift-ci[bot] commented 5 days ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zdtsw

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/opendatahub-io/opendatahub-operator/blob/feature-operator-refactor/OWNERS)~~ [zdtsw] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

codecov[bot] commented 5 days ago

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Please upload report for BASE (feature-operator-refactor@d748e02). Learn more about missing BASE report.

Files with missing lines	Patch %	Lines
pkg/services/gc/gc.go	0.00%	1 Missing :warning:

Additional details and impacted files

```diff @@ Coverage Diff @@ ## feature-operator-refactor #1392 +/- ## ============================================================ Coverage ? 26.85% ============================================================ Files ? 60 Lines ? 4782 Branches ? 0 ============================================================ Hits ? 1284 Misses ? 3349 Partials ? 149 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.