feat: added integration tests to cover evicted pods in post conditions

opendatahub-io / opendatahub-operator

Open Data Hub operator to manage ODH component integrations

https://opendatahub.io

Apache License 2.0

62 stars 144 forks source link

feat: added integration tests to cover evicted pods in post conditions #1399

Open Al-Pragliola opened 4 days ago

Al-Pragliola commented 4 days ago

Tracking issue: RHOAIENG-15614

Description

Seeing that testing in a real cluster can be quite problematic, I added integration tests to cover scenarios with evicted pods, I didn't add a negative test because it takes 5 minutes to fail and the timeout duration is not configurable.

How Has This Been Tested?

make test

Screenshot or short clip

Merge criteria

[ ] You have read the contributors guide.
[ ] Commit messages are meaningful - have a clear and concise summary and detailed explanation of what was changed and why.
[ ] Pull Request contains a description of the solution, a link to the JIRA issue, and to any dependent or related Pull Request.
[ ] Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
[ ] The developer has manually tested the changes and verified that the changes work

openshift-ci[bot] commented 4 days ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign ugiordan for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/opendatahub-io/opendatahub-operator/blob/incubation/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

codecov[bot] commented 4 days ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Please upload report for BASE (incubation@c1671ab). Learn more about missing BASE report.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## incubation #1399 +/- ## ============================================= Coverage ? 18.91% ============================================= Files ? 30 Lines ? 3399 Branches ? 0 ============================================= Hits ? 643 Misses ? 2687 Partials ? 69 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Al-Pragliola commented 3 days ago

/cc @zdtsw