Add reusable functions to add/remove/update ReconciliationRequest.Resources

opendatahub-io / opendatahub-operator

Open Data Hub operator to manage ODH component integrations

https://opendatahub.io

Apache License 2.0

62 stars 144 forks source link

Add reusable functions to add/remove/update ReconciliationRequest.Resources #1401

Closed lburgazzoli closed 2 days ago

lburgazzoli commented 3 days ago

Description

How Has This Been Tested?

Screenshot or short clip

Merge criteria

[x] You have read the contributors guide.
[x] Commit messages are meaningful - have a clear and concise summary and detailed explanation of what was changed and why.
[ ] ~~Pull Request contains a description of the solution, a link to the JIRA issue, and to any dependent or related Pull Request.~~
[x] Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
[ ] ~~The developer has manually tested the changes and verified that the changes work~~

lburgazzoli commented 3 days ago

@grdryn this may be useful for resources manipulation i.e. replaceResourceAtIndex in kserve PR

codecov[bot] commented 3 days ago

Codecov Report

Attention: Patch coverage is 70.37037% with 8 lines in your changes missing coverage. Please review.

Please upload report for BASE (feature-operator-refactor@6281fdd). Learn more about missing BASE report.

Files with missing lines	Patch %	Lines
pkg/controller/types/types.go	70.37%	5 Missing and 3 partials :warning:

Additional details and impacted files

```diff @@ Coverage Diff @@ ## feature-operator-refactor #1401 +/- ## ============================================================ Coverage ? 27.20% ============================================================ Files ? 61 Lines ? 4889 Branches ? 0 ============================================================ Hits ? 1330 Misses ? 3404 Partials ? 155 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

lburgazzoli commented 3 days ago

Marked as a draft, let's have the other component related PRs merged first

openshift-ci[bot] commented 2 days ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zdtsw

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/opendatahub-io/opendatahub-operator/blob/feature-operator-refactor/OWNERS)~~ [zdtsw] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

lburgazzoli commented 2 days ago

/test opendatahub-operator-e2e