opendatahub-io / opendatahub-operator

Open Data Hub operator to manage ODH component integrations
https://opendatahub.io
Apache License 2.0
59 stars 130 forks source link

Update Dockerfile to include component manifests #424

Closed VaishnaviHire closed 10 months ago

VaishnaviHire commented 1 year ago

checklist for left components in ODH:

operator:

zdtsw commented 1 year ago

to catch the offline conversation:

each component has their manifests already in their repo. this issue is to fetch these manifests from different git repo (instead of from one central odh-manifests) and place them in the correct local in the final image, e.g /opt/manifests//...

will start with "main" branch from these git repo and check with each component which branch will suit best and updated if required.

zdtsw commented 1 year ago

list of what we are using from odh-manifests as

special cases for downstream:

zdtsw commented 1 year ago

@VedantMahabaleshwarkar / @Jooho Could you point to me where manifests in https://github.com/opendatahub-io/odh-manifests/tree/master/model-mesh came from?

zdtsw commented 1 year ago

@harshad16 could you take a look how to make the nb/nbc part work?

workbench1: https://github.com/opendatahub-io/odh-manifests/tree/master/notebook-images > where this one maps from
 workbench2: https://github.com/opendatahub-io/odh-manifests/tree/master/odh-notebook-controller > where this one maps from
zdtsw commented 1 year ago

we still would need a params.env file placed in https://github.com/opendatahub-io/kserve/tree/master/config/overlays , something simliar to https://github.com/red-hat-data-services/odh-manifests/blob/master/kserve/base/params.env @danielezonca

harshad16 commented 1 year ago

@zdtsw Apologies for the delay. We have finally included the manifests in the repos. Can you please update the above comment with these links:

These contain the base folder for Kustomize to execute. Thank for the patience and support.

zdtsw commented 1 year ago

@zdtsw Apologies for the delay. We have finally included the manifests in the repos. Can you please update the above comment with these links:

These contain the base folder for Kustomize to execute. Thank for the patience and support.

thanks @harshad16 i have commited your suggestion in ADR and will include nbc change as well in operator

Jooho commented 12 months ago

@zdtsw the manifests are from modelmesh-serving/opendatahub/odh-manifests/model-mesh_stable for now.