The dependencies are needed for the components

adelton commented 1 year ago

Description

The dependencies are needed for the components, not for the DataScienceCluster instance. Let's not complicate steps for setting up the DataScienceCluster instance with something which will only become relevant later.

Fixes https://github.com/opendatahub-io/opendatahub.io/issues/188.

How Has This Been Tested?

Not tested.

Merge criteria:

[ ] The commits are squashed in a cohesive manner and have meaningful messages.
[ ] Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
[ ] The developer has manually tested the changes and verified that the changes work

shalberd commented 1 year ago

agreed. For example, if someone does not enable Pipelines or Model Serving, they don't need certain of those dependencies mention, yeah. Looks good to me.

adelton commented 1 year ago

Thanks @shalberd. What's the next process in this project? Do I push an agreed pull request directly, or does some other maintainer push, or something else?

shalberd commented 1 year ago

Hi @adelton a maintainer such as @Gkrumbach07 or @LaVLaS or @VaishnaviHire needs to make a lgtm comment and then merge it, I think.

Gkrumbach07 commented 1 year ago

i see no issue with the changes /lgtm

opendatahub-io / opendatahub.io