search

opendatalab-de / geojson-jackson

GeoJson POJOs for Jackson - serialize and deserialize objects with ease
http://blog.opendatalab.de
Apache License 2.0
263 stars 94 forks source link

Improve pom.xml #24

Closed pigelvy closed 8 years ago

pigelvy commented 8 years ago

Replace mockito-all by mockito-core (@see https://github.com/mockito/mockito/wiki/Declaring-mockito-dependency)

Add dependency to hamcrest-library 1.3 (better matchers)

grundid commented 8 years ago

I'm sorry, but I don't understand why we should add "hamcrest-library" as a dependency here.

We are not using the hamcrest matchers here.

pigelvy commented 8 years ago

The thing that is certain is that mockito-all should be replaced by mockito-core.

After, I always depend on mockito-library because there are many useful matchers. You may not be using them right now, but once available, you should replace some tests.

For example, I prefer using the IsCloseTo() rather than assertEquals(double, double, double).

Le 14 nov. 2015 à 20:28, Adrian Stabiszewski notifications@github.com a écrit :

I'm sorry, but I don't understand why we should add "hamcrest-library" as a dependency here.

We are not using the hamcrest matchers here.

— Reply to this email directly or view it on GitHub.

grundid commented 8 years ago

I agree that we should switch to mockito-core, but I'll add hamcrest-library if we really need the matchers from that library.