search

opendatalab-de / geojson-jackson

GeoJson POJOs for Jackson - serialize and deserialize objects with ease
http://blog.opendatalab.de
Apache License 2.0
263 stars 94 forks source link

Get rid of explicit dependency to jackson-core... #39

Closed pigelvy closed 7 years ago

pigelvy commented 7 years ago

... because "jackson-databind" already depends on "jackson-core" and because they both evolve at the same time.

grundid commented 7 years ago

It's true that "jackson-databind" depends on "jackson-core", but our code depends on "jackson-core" directly. Therefore it is good practice to include this dependency in our pom. If "jackson-databind" some day makes "jackson-core" optional our code will not compile.

pigelvy commented 7 years ago

I still haven't clearly made my mind on what is best between declaring always everything, or leveraging the transitive mechanisms of Maven...

For example, geojson-jackson depends on jackson-annotations and, yet, do not declare an explicit dependency to it.

As far as I am concerned, I tend to declare explicitly transitive dependencies when I want to or need to force the usage of specific versions.

grundid commented 7 years ago

Yes, thanks for pointing this out.