search

opendataphilly / opendataphilly-jkan

OpenDataPhilly powered by JKAN
https://opendataphilly.org/
MIT License
16 stars 12 forks source link

HTML tags in dataset entries are rendered as text #67

Closed rcheetham closed 4 months ago

rcheetham commented 1 year ago

There are HTML tags (and possibly some markdown) in dataset descriptions. These are being display as HTML, rather than interpreted.

I don't know if we should treat this as a bug or find a way to strip out all of the tags and replace them with line breaks. Some examples in search results and on a data set page below:

image

image

BryanQuigley commented 1 year ago

AFAICT from my grep this is only septa datasets and one "Bike Network - Supporting Datasets"

Supporting in-line HTML in markdown is more complicated and I think this should just be removed/modified to be markdown.

arigas2 commented 1 year ago

My understanding for how these markdown files are created, is that they were created from the import process from CKAN. Going forward, a new dataset markdown file would be created manually. Is this understanding correct?

BryanQuigley commented 1 year ago

Yes manually (or technically using Decap CMS but that's not easily setup here at the moment).

For this case though it would be manually updating the existing files to remove the html tags and replace with markdown if possible. Note although generic I believe this mostly affects Septa so this is related to #66

rcheetham commented 4 months ago

@BryanQuigley I think this might be partially fixed. I did a lot of editing on SEPTA this weekend and some HTML tags seem to be rendering ok. I also checked the referenced "Bike Network" data set and it seems to be fine.

But some tags still don't render.
is an example.

BryanQuigley commented 4 months ago

< /br > above. Yes it seems to be mostly fixed but seems to be a strick subset of tags, but that seems fine.