ability to define multiple series based on different datasets to a chart in a simple way

opendatasoft / ods-widgets

Components to easily build visualizations and interfaces from a data API.

MIT License

27 stars 11 forks source link

ability to define multiple series based on different datasets to a chart in a simple way #27

Open Amli opened 9 years ago

Amli commented 9 years ago

    <ods-dataset-context context="hurricanes,killings" hurricanes-domain="public.opendatasoft.com" hurricanes-dataset="hurricane-tracks-1851-20071" killings-dataset="killings-by-law-enforcement-officers-in-the-usa" killings-domain="public.opendatasoft.com">
        <ods-highcharts>
                <ods-chart-serie context="hurricanes" field-x="track_date" chart-type="line" timescale="year" function-y="COUNT"></ods-chart-serie>
                <ods-chart-serie context="killings" field-x="date" chart-type="line" timescale="year" function-y="COUNT"></ods-chart-serie>
        </ods-highcharts>
    </ods-dataset-context>

this should allow for complex charts to be displayed and manipulated from other widgets. superseeds #7

richterb commented 9 years ago

Two side remarks/questions:

we should support the old syntax as a specific case of this, e.g.

<ods-highcharts>
    <ods-chart-serie context="hurricanes" field-x="track_date" chart-type="line" timescale="year" function-y="COUNT"></ods-chart-serie>
</ods-highcharts>

is the same as

<ods-highcharts context="hurricanes" field-x="track_date" chart-type="line" timescale="year" function-y="COUNT"></ods-highcharts>

how does is work when we try to draw two expressions from the same context? do we just have two ods-chart-serie with the same context, and the code automagically merges them?

richterb commented 9 years ago

(note that in my opinion the transparent merge would be ideal, as it doesn't require us - or the user - to add another level of concepts that doesn't bring any end-user benefit)

Amli commented 9 years ago

old syntax will be supported for backward compatibility's sake
for multiple series linked to the same context the ideal would to merge them transparently but we need to find a way to set global chart parameters for each queries... so it will probably not be that transparent.