search

opendatateam / docker-udata

udata and plugins all-in-one Docker image
https://hub.docker.com/r/udata/udata/builds
MIT License
15 stars 12 forks source link

Make "scalable" the default setup? #59

Open abulte opened 6 years ago

abulte commented 6 years ago

Why not use a dedicated service for the worker? It would allow us to bypass some uwsgi complexity and mirror more closely our production setup.

abulte commented 6 years ago

My bad, this is already available in https://github.com/opendatateam/docker-udata/blob/master/samples/scalable/docker-compose.yml. Maybe this should be the default setup? It fail to see the definitive advantage of the "simple" configuration since the complexity of the setup is abstracted by docker-compose.

abulte commented 6 years ago

Using one less setup would also reduce maintenance overhead.

noirbizarre commented 6 years ago

The default root setup is simple and should stay like it. It's meant for development purpose on this docker image. Those extra configurations are samples (peopleasked for it) for quick testing but this repository is not meant to be cloned for production or demo purpose. The scalable setup adds a lot of complexity (which is undesired for developoment) and most of the time you will need some more configuration to match your needs.

Anyway, we can add some details in the readme to test the scalable setup, something like:

curl https://raw.githubusercontent.com/opendatateam/docker-udata/master/samples/scalable/docker-compose.yml > docker-compose.yml
docker-compose up