opendatateam / udata

Customizable and skinnable social platform dedicated to open data.
http://udata.readthedocs.org
GNU Affero General Public License v3.0
239 stars 87 forks source link

Re-add extras to datasets search index? #1719

Open abulte opened 6 years ago

abulte commented 6 years ago

This feature has been removed https://github.com/opendatateam/udata/pull/1718 because our extras key validation was not enough for Elastic Search constraints (no spaces...).

We might want to add the feature back correctly if someone really needs it.

teleboas commented 6 years ago

We might have a use-case. The open-contracting datasets will be published by procurement portals on behalf of local governments and other buyers using their services. They might be published as one dataset per procurement portal, or as one dataset for each buyer. In the second case we need to find a way to look for those datasets by buyer. For now those buyers are uniquely identified by their French SIRET number. We were thinking of storing this number in a siret extra but we would need it to be searchable. The alternatives (forcing the SIRET number in the title, description or tags) are not very palatable.

teleboas commented 6 years ago

We definitely have the aforementioned use-case. Could we reintroduce extras in the search index at least for some keys (either some specifically white listed keys, or all the ones respecting ES constraints)?

abulte commented 4 years ago

This is definitely something that can be useful.