opendatateam / udata

Customizable and skinnable social platform dedicated to open data.
http://udata.readthedocs.org
GNU Affero General Public License v3.0
241 stars 88 forks source link

Fix dataservice metadata_modified_at update in API #3207

Open maudetes opened 20 hours ago

maudetes commented 20 hours ago

Use the correct wording when updating the metadata_modified_at field in API PATCH and DELETE calls.

This field is also used as a key in the cache value in udata-front.

maudetes commented 4 hours ago

Nice! So many different modified and created variations throughout the code 😱 One day, for sure, we'll fix all of them, right? :P

I actually hesitated between fixing this by using the actual field or by renaming the fields to the one used in other main collections (using db.Datetimed). I did not go down this path for this quickfix, but I think we should seriously take a look as long as dataservices are marked as beta. I think @Pierlou would be glad too.

magopian commented 4 hours ago

Yeah, this quickfix makes total sense, and yes, fixing the incoherences will probably take some tinkering and some time ... in the future ;)