opendatatrentino / jackan

Java client to access CKAN repositories
http://opendatatrentino.github.io/jackan
Other
19 stars 13 forks source link

Add resources iteration #29

Closed deinok closed 8 years ago

deinok commented 8 years ago

This enables the feature of do

dataset.addResource(new CkanResource(foo),new CkanResource(foo));

Some warnings fixed like ArrayList() to ArrayList<>()

DavidLeoni commented 8 years ago

Thanks!

Some points:

 if (obj == null) {     
    return false;       
 }

to

 if (o == null) return false;`  

I would prefer to keep original format, because actually other linters can like it more.

deinok commented 8 years ago

@DavidLeoni thanks for the quick response

deinok commented 8 years ago

@DavidLeoni Is Eclipse the default IDE for this project?

DavidLeoni commented 8 years ago

I will use Eclipse in next PR, i was using IntelliJ, if IntelliJ support syle.xml i will use it.

Eclipse is the main IDE for Jackan. Next in line for support is Netbeans. Seems like IntelliJ allows using Eclipse style natively and also with a plugin, if one of them works for you let me know and I will update the wiki.

Equals and HashCode, i will use your style. Also I think that every Class in models shoud have Equals an HashCode, are you ok?

ok! So far I tried to keep the model lightweight but we can start adding some bells and whistles. If you want to add the equals and hashcodes please make a separate pull request just for them.