search

opendatatrentino / jackan

Java client to access CKAN repositories
http://opendatatrentino.github.io/jackan
Other
19 stars 13 forks source link

Upload of a resource's data file (creation and update) #34

Closed bobeal closed 8 years ago

bobeal commented 8 years ago

Hello,

As discussed two weeks ago, here is the PR for the management of a resource's data file.

Do not hesitate to contact me if some things have to be re-worked.

Regards,

Benoit.

DavidLeoni commented 8 years ago

Thank you very much, looks like a clean commit!

I have one question about file sizes: Have you tried to upload files of several megabytes? I think a test case for that would make us sure everything is going to work properly with ckan (In case try to generate the file on the fly to prevent storing too big stuff in the repo, as far as I remember datahub.io supports max 100mb).

bobeal commented 8 years ago

Hello,

Here are some more commits to fix what we talked about.

Regards,

Benoit.

bobeal commented 8 years ago

Hi,

Any news on this PR ? Do you plan to merge it soon ?

Regards,

Benoit.

DavidLeoni commented 8 years ago

Sorry for the delay, I got busy with deadlines.

Thank you very much for the pull request, it's a very nice improvement. I only added some documentation and CkanResourceBase.setUpload(File) to still have a bean-style setter.