search

opendatatrentino / jackan

Java client to access CKAN repositories
http://opendatatrentino.github.io/jackan
Other
19 stars 13 forks source link

SNI Issues with included httpclient version #37

Closed ridoo closed 8 years ago

ridoo commented 8 years ago

Hey guys,

I'm using Jackan 0.4.2 to connect to an SSL secured server using SNI (Server Name Identification). I think there's a problem with the httpclient version (currenlty 4.3.1, above version shouldn't be affected) included by the shade plugin.

I tried with version 4.3.3 (httpclient has a version 4.3.6 but httpcore did not so I chose the common version) and this worked out. Probably I could also use an even higher version of httpclient but I don't know if you rely on other parts of the API, though.

PR is in progress ...

BTW: Is there a reason why you include all sources and ship the stuff? This led me checkout the sources and patch the pom.xml. Wouldn't a plain dependency work out the same?

Thanks.

DavidLeoni commented 8 years ago

BTW: Is there a reason why you include all sources and ship the stuff? This led me checkout the sources and patch the pom.xml. Wouldn't a plain dependency work out the same?

My main concern is that Apache Http stuff is shared by many projects, so dependency conflicts are more likely to happen. This particular case works well as example, just a little 0.0.2 increment completely prevented Jackan from writing at all! Also, when I see a library at version 4 I expect it to be quite good and not likely to change much, but of course this is a total guess :-)