Addressing the system.out lines throughout the project.

[wjonassen]

Problem Description

There are system.out's in the project. We want to either remove them completely (if they are not useful), or replace those with SLF4J in the case that they are useful.

Fixes #79.

Solution

In the cases where it's a system.out that's not useful (maybe it's a debug line), remove it completely. If it is useful, then convert it into slf4j.

how you tested the change

Verify the project builds.

Where the following done:

• [ ] Tests. Check all that apply:
  • [ ] Unit tests created or modified that run during ant test.
  • [ ] Integration tests created or modified that run during integration testing (Formerly called regression tests.)
  • [ ] Test procedure descriptions for manual testing
• [ ] Was relevant documentation updated?
• [ ] Were relevant config element (e.g. XML data) updated as appropriate

[wjonassen]

@MikeNeilson I have addressed a bunch of the system.out's in this. There are still more, but if you could go through some of the changes to make sure I'm addressing them appropriately, I can then finish off the rest of them.

I am removing the ones where they really shouldn't be there, converting some to slf4j logging, and converting some to thrown exceptions.

[wjonassen]

Looks like a reasonable start to me.

Ok, sounds good. I will address the rest of the system.out's and 'undraft' this PR.

[sonarcloud[bot]]

Quality Gate failed

Failed conditions
3.5% Coverage on New Code (required ≥ 80%)
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

[wjonassen]

Looks like a reasonable start to me.

@MikeNeilson I know you did approve this yesterday, but I have just added the rest of the updates for addressing the system.out's and don't want to merge until the new changes are approved (or updates are needed).