opendcs / rest_api

Rest API that serves OpenDCS database objects as JSON
Apache License 2.0
1 stars 3 forks source link

Fix empty catch blocks #196

Open adamkorynta opened 1 month ago

adamkorynta commented 1 month ago

Describe the bug ConsistencyNot conventional Either log or rethrow this exception.

Exception handlers should preserve the original exceptions java:S1166 Software qualities impacted: Maintainability

To Reproduce https://sonarcloud.io/project/issues?languages=java&rules=java%3AS1166&issueStatuses=OPEN%2CCONFIRMED&id=opendcs_rest_api

Expected behavior Logged exceptions (even if low log level)

Additional context Mentioned in: https://github.com/opendcs/rest_api/pull/186#discussion_r1778928668