opendcs / rest_api

Rest API that serves OpenDCS database objects as JSON
Apache License 2.0
1 stars 2 forks source link

org.eclipse.jetty:jetty-jsp is referenced in the tomcat build.gradle #92

Open wjonassen opened 8 months ago

wjonassen commented 8 months ago

Describe the bug org.eclipse.jetty:jetty-jsp is referenced in the opendcs-web-client dependencies, but it probably should be in the jetty version. The issue is that when it is removed in the current implementation, the jetty version stops working. The browser comes back with the following error: HTTP ERROR 500 org.apache.jasper.JasperException: PWC6033: Error in Javac compilation for JSP PWC6199: Generated servlet error: package org.apache.jasper.runtime does not exist PWC6199: Generated servlet error: package org.apache.jasper.runtime does not exist PWC6199: Generated servlet error: package org.glassfish.jsp.api does not exist PWC6199: Generated servlet error: incompatible types: org.apache.jsp.sites_jsp cannot be converted to javax.servlet.Servlet PWC6199: Generated servlet error: package org.glassfish.jsp.api does not exist PWC6197: An error occurred at line: 4 in the jsp file: /sites.jsp PWC6199: Generated servlet error: package org.apache.jasper.runtime does not exist PWC6197: An error occurred at line: 7 in the jsp file: /sites.jsp PWC6199: Generated servlet error: package org.apache.jasper.runtime does not exist PWC6197: An error occurred at line: 12 in the jsp file: /sites.jsp PWC6199: Generated servlet error: package org.apache.jasper.runtime does not exist PWC6197: An error occurred at line: 55 in the jsp file: /sites.jsp PWC6199: Generated servlet error: package org.apache.jasper.runtime does not exist PWC6197: An error occurred at line: 247 in the jsp file: /sites.jsp PWC6199: Generated servlet error: package org.apache.jasper.runtime does not exist PWC6199: Generated servlet error: Some messages have been simplified; recompile with -Xdiags:verbose to get full output

To Reproduce In the opendcs-web-client build.gradle, remove the following line: implementation(libs.jetty.jsp) Build the opendcs-web-client-jetty installer by running ./gradlew :opendcs-web-client-jetty:bundle Run it and load a browser webpage pointed to the jetty instance. The browser will appear with the displayed error.

Expected behavior The web GUI should appear with no errors.

Desktop/ServerSide (please complete the following information):