Tasks for Isabella's onboarding (Octopus). #20

Closed scoiatael closed 1 year ago

In GitLab by @nikitamironov on Feb 3, 2020, 17:33

Bigger ones

These tasks will take 4-8 weeks to execute.

Octopus 3 changes.

Depending on complexity of change it will take different amount of time. It's categorized as bigger task because even for little change we will have to update all the converters, tests, schema and communitcate changes across all teams.

Writers.

Also bigger task because we need to analyze the file structure of resulting file + Octopus + possible caveats when converting.

JS Sketch parser

JS implementation of Go Sketch parser.

Exportables

Research and add into Octopus information about what user marked as exportable. Not that big, but it requires to change all converters where this feature is available.

Smaller ones

[ ] XD Uppercase https://gitlab.avcd.cz/backend/backend/issues/1499
[x] Figma text ranges bug https://gitlab.avcd.cz/backend/backend/issues/1888
[ ] Remove constructor.name https://gitlab.avcd.cz/avocode/octopus-symbol-expander/issues/30
[x] Empty value on text layers https://gitlab.avcd.cz/avocode/avocode/issues/6840
[ ] Protomerger issue (I guess, we need to investigate) https://gitlab.avcd.cz/backend/octopus-protomerger/issues/3
[ ] Figma text transform https://gitlab.avcd.cz/backend/octopus-figma/issues/19
[x] Mask/opacity bug https://gitlab.avcd.cz/backend/backend/issues/1596
[ ] Figma design version info https://gitlab.avcd.cz/backend/figma-parser/issues/12
[ ] Something weird https://gitlab.avcd.cz/avocode/octopus-symbol-expander/issues/29
[x] Letterspacing in xd https://gitlab.avcd.cz/backend/backend/issues/1278

Few more tasks:

[ ] Rectangle corner radius incorrectly limited https://gitlab.avcd.cz/avocode/octopus-xd/issues/34
[ ] Add blendMode prop https://gitlab.avcd.cz/avocode/octopus-xd/issues/33

I've filtered issues that are quite easy to start work with, although she will still need some kind of consultation.

In GitLab by @rychlis on Feb 13, 2020, 14:27

marked the checklist item Figma text ranges bug https://gitlab.avcd.cz/backend/backend/issues/1888 as completed

In GitLab by @rychlis on Feb 13, 2020, 14:27

marked the checklist item Figma text transform https://gitlab.avcd.cz/backend/octopus-figma/issues/19 as completed

In GitLab by @rychlis on Feb 13, 2020, 14:27

marked the checklist item Figma text transform https://gitlab.avcd.cz/backend/octopus-figma/issues/19 as incomplete

In GitLab by @rychlis on Feb 13, 2020, 14:28

marked the checklist item Protomerger issue (I guess, we need to investigate) https://gitlab.avcd.cz/backend/octopus-protomerger/issues/3 as completed

In GitLab by @rychlis on Feb 13, 2020, 14:28

marked the checklist item Protomerger issue (I guess, we need to investigate) https://gitlab.avcd.cz/backend/octopus-protomerger/issues/3 as incomplete

In GitLab by @rychlis on Feb 13, 2020, 14:28

marked the checklist item Empty value on text layers https://gitlab.avcd.cz/avocode/avocode/issues/6840 as completed

In GitLab by @rychlis on Feb 13, 2020, 14:28

marked the checklist item Letterspacing in xd https://gitlab.avcd.cz/backend/backend/issues/1278 as completed

In GitLab by @isbl on Feb 17, 2020, 13:50

exportables research

figma

https://help.figma.com/hc/en-us/articles/360040028114-Getting-Started-with-Exports

https://help.figma.com/hc/en-us/articles/360040514533#id

size: 0x 0w 0h
suffix
format: png, jpeg, svg, pdf
contents only
- on slice it means only stuff in same parent group
- doesnt seem to do anything on non-slice
svg only stuff
- Include "id" Attribute
- Outline Text: converts texts to paths
  - not available on slices
  - only available on groups containing texts or texts themselves
- Simplify Stroke (I wasnt able to trigger that)

Adobe XD

only mark for export
- basically contents only setting from figma

Sketch

slice
- equivalent of slice without content only in figma
layer
- equivalent of export on layer in figma
size: 0x 0w 0h
prefix/suffix
format: png, jpeg, tiff, webp, pdf, eps, svg
svg doesnt allow specifying size
jpeg is not transparent - replaces transparent stuff with white
- artboard background is included only for slices (makes sense) and only if marked as exported
slices:
- background color
- trim transparent pixels (doesnt make sense with bg color)

representation in files

figma

{
    "suffix": "",
    "format": "SVG",
    "constraint": {
        "type": "SCALE",
        "value": 1
    }
}

xd

meta.ux.markedForExport: true

sketch

{
    "_class": "exportOptions",
    "includedLayerIds": [],
    "layerOptions": 0,
    "shouldTrim": false,
    "exportFormats": [
        {
            "_class": "exportFormat",
            "absoluteSize": 0,
            "fileFormat": "tiff",
            "name": "",
            "namingScheme": 0,
            "scale": 1,
            "visibleScaleType": 0
        },
        {
            "_class": "exportFormat",
            "absoluteSize": 500,
            "fileFormat": "webp",
            "name": "test",
            "namingScheme": 1,
            "scale": 3.472222222222222,
            "visibleScaleType": 1
        }
    ]
}

proposed octopus

new layer type: sliceLayer
- x,y,w,h
new key on layer: exportables/exportSettings
- array
- omitted when no export there
- schema of element
  - size: 0x / 0w / 0h
  - namingScheme: prefix / suffix
  - name: the actual prefix
  - format: png / jpeg / tiff / webp / pdf / eps / svg
  - ?format supports transparency: boolean
  - background color: color
  - trim transparent pixels: boolean

stacking of backgrounds:

background of exportable
background of artboard (maybe resolve this in octopus and put it into exportable bg?)
elements themselves

In GitLab by @isbl on Feb 18, 2020, 11:35

new key on root of octupus exportables. Array of:

type: slice/layer
bounds (slice only)
outputSize: {mode, value}
location: {id, parent, index}
naming: {scheme, value}
format
backgroundColor: {value, enabled}
trimTransparentPixels

In GitLab by @viktorchlumsky on Feb 18, 2020, 14:55

marked the checklist item Mask/opacity bug https://gitlab.avcd.cz/backend/backend/issues/1596 as completed

In GitLab by @rychlis on May 19, 2020, 15:39

closed

opendesigndev / octopus-specs