Build and publish CI to public NPM as experimental

rychlis commented 1 year ago

Runs CI and publishes experimental package on each commit in PRs that changes the path

Before merge:

[x] Remove force-ci files (needed them to start the CI as the CI only runs when a path changes)
[ ] Squash into one commit

For next PR

[ ] Add job that publishes normal version on tag push

rychlis commented 1 year ago

Oh so there is one thing that doesn't work right now - somehow github started ignoring the on.pull_request.path and on.push.paths completely 🤷

rychlis commented 1 year ago

Oh so there is one thing that doesn't work right now - somehow github started ignoring the on.pull_request.path and on.push.paths completely 🤷

Yeah so somehow i thought the on.*.path limitation is comparing changes to the previous push, but it's actually comparing all changes in PR against the base branch (main in this case). So if you change something in octopus-fig in the PR, all subsequent commits will run figma publish in that PR. In some cases this might publish more packages than you want - from my experience even if you rebase the branch on latest main, all changes in main count as changes in the path

So these are the options now

Use manual dispatch - would need to use the gh CLI, more info here
Current setup - publish-experimental label will start publishing every package that was changed in a PR
We could have multiple labels for each package, like publish-experimental-psd etc to control what you want to publish

rychlis commented 1 year ago

IMO this setup is good enough, I made an issue with options to do even better solution in the future: https://github.com/opendesigndev/octopus/issues/89

For now, just add publish-experimental label to start publishing and remove it if you no longer want to publish new commits @cerosnikita . Pls approve the PR so we can start using this

rychlis commented 1 year ago

Sorry I will remove the force ci files and squash commits now

rychlis commented 1 year ago

Files removed. Just use squash and merge for merging

rychlis commented 1 year ago

squased and opened in separate branch https://github.com/opendesigndev/octopus/pull/100

opendesigndev / octopus

Build and publish CI to public NPM as experimental #85