opendevstack / ods-core

The core of OpenDevStack - infrastructure setup based on Atlassian tools, Jenkins, Nexus, SonarQube and shared images
Apache License 2.0
47 stars 34 forks source link

Error adding ALLOWED_CHANGE_REF_TYPES as env variable #1252

Open aoteropas opened 10 months ago

aoteropas commented 10 months ago

https://github.com/opendevstack/ods-core/blob/0e02f3466cdd6f6e80a2c3a7d45509ff72f0ca97/jenkins/webhook-proxy/main.go#L207C18-L207C18

When:

Expected result:

Actual result:

Analysis: The if clause is not checking the variable that retrieves en env information, is checking the empty array that will contain it after spliting (done inside the if)

michaelsauter commented 10 months ago

Ouch! Want to contribute a fix?

metmajer commented 10 months ago

Thanks for the fix @aoteropas. @braisvq1996 @jafarre-bi please include it in our next release.