cd-user secrets duplicated in central namespace

opendevstack / ods-core

The core of OpenDevStack - infrastructure setup based on Atlassian tools, Jenkins, Nexus, SonarQube and shared images

Apache License 2.0

47 stars 34 forks source link

cd-user secrets duplicated in central namespace #530

Open michaelsauter opened 4 years ago

michaelsauter commented 4 years ago

General setup creates a secret named cd-user-token, and the Jenkins installation creates a secret named cd-user-with-password. Both have the same information. We should keep just one.

cd-user-with-password is shipped with the Jenkins template, which might not be ideal. Maybe better to install that separately, also for new projects.

FYI @oalyman

clemensutschig commented 4 years ago

Keep in mind that this secret needs to be a Source secret of a bc to be syncd to jenkins

clemensutschig commented 4 years ago

this is the project specific one - (which one needs to modify assuming you use a 'per project user') https://github.com/opendevstack/ods-core/blob/master/jenkins/ocp-config/deploy/jenkins-master.yml#L66-L75 - and it#s created in create-project jenkins job
the cd-user-token - should only be in the root / main namespace - and is the 'global' one https://github.com/opendevstack/ods-core/search?q=cd-user-token&unscoped_q=cd-user-token

michaelsauter commented 4 years ago

Yes - the duplication is only in the global ods namespace.

clemensutschig commented 4 years ago

then we should just rename it to - say global-cd.. - thoughts?

michaelsauter commented 4 years ago

I'll move this to v4 as I don't see it that crucial ...