search

opendevstack / ods-core

The core of OpenDevStack - infrastructure setup based on Atlassian tools, Jenkins, Nexus, SonarQube and shared images
Apache License 2.0
47 stars 34 forks source link

ODS box build has been failing since 2020-09-01 12:00 #795

Closed georgfedermann closed 4 years ago

georgfedermann commented 4 years ago

Describe the bug During ODS box AMI build the cypress tests are failing with the logs quoted below.

To Reproduce Steps to reproduce the behavior:

  1. Run quickstarter tests in a fresh ODS box
  2. See error

Expected behavior The tests should pass

Affected version (please complete the following information):

Log Output (ensure to remove any confidential information like tokens, project names, etc.

    amazon-ebs: /tmp/workspace/unitt-cd/unitt-cd-run-unitt-cypress-unitt-master/node_modules/cypress/types/net-stubbing.ts:7:15
    amazon-ebs: ERROR: 7:15    semicolon           Missing semicolon
    amazon-ebs: ERROR: 8:39    semicolon           Missing semicolon
    amazon-ebs: ERROR: 9:16    semicolon           Missing semicolon
    amazon-ebs: ERROR: 10:20   semicolon           Missing semicolon
    amazon-ebs: ERROR: 11:25   semicolon           Missing semicolon
    amazon-ebs: ERROR: 17:4    semicolon           Missing semicolon
    amazon-ebs: ERROR: 23:59   unified-signatures  This overload and the one on line 29 can be combined into one signature with an optional parameter.
...
    amazon-ebs: WARNING: Unknown parameter(s) found for class type 'org.jenkinsci.plugins.workflow.steps.durable_task.ShellStep': label
    amazon-ebs: + curl --fail --silent --request POST --header 'Authorization: Bearer ****' --header 'Content-Type: application/json' --data '{"state":"FAILED","key":"d11e84ae","name":"d11e84ae","url":"https://jenkins-unitt-cd.ocp.odsbox.lan/job/unitt-cd/job/unitt-cd-run-unitt-cypress-unitt-master/1/"}'http://bitbucket.odsbox.lan:7990/rest/build-status/1.0/commits/d11e84ae779df9dff861783159caf4bbe95b2cea
...
    amazon-ebs: Finished: FAILURE
    amazon-ebs: build pipeline run for cypress returned:
    amazon-ebs: [
    amazon-ebs:   {
    amazon-ebs:     "stage": "odsPipeline start",
    amazon-ebs:     "status": "SUCCESS"
    amazon-ebs:   },
    amazon-ebs:   {
    amazon-ebs:     "stage": "Integration Test",
    amazon-ebs:     "status": "FAILED"
    amazon-ebs:   },
    amazon-ebs:   {
    amazon-ebs:     "stage": "odsPipeline error",
    amazon-ebs:     "status": "FAILED"
    amazon-ebs:   }
    amazon-ebs: ]
...
    amazon-ebs: Run step #4 (upload) of quickstarter release-manager ...
    amazon-ebs: Uploaded file fixtures/metadata.yml to http://bitbucket.odsbox.lan:7990--- FAIL: TestQuickstarter (7670.44s)
    amazon-ebs:     --- PASS: TestQuickstarter/be-fe-mono-repo-plain (268.75s)
    amazon-ebs:     --- PASS: TestQuickstarter/be-gateway-nginx (268.04s)
    amazon-ebs:     --- PASS: TestQuickstarter/be-golang-plain (306.73s)
    amazon-ebs:     --- PASS: TestQuickstarter/be-java-springboot (411.13s)
    amazon-ebs:     --- PASS: TestQuickstarter/be-python-flask (341.09s)
    amazon-ebs:     --- PASS: TestQuickstarter/be-scala-play (481.03s)
    amazon-ebs:     --- FAIL: TestQuickstarter/be-typescript-express (410.96s)
    amazon-ebs:         quickstarter_test.go:286: Could not find unit tests for build:run-unitt-typescript-iq-test-unitt-master-1
    amazon-ebs:             stdout: Using https://jenkins-unitt-cd.ocp.odsbox.lan/job/unitt-cd/job/unitt-cd-run-unitt-typescript-iq-test-unitt-master/1//testReport calculated from run-unitt-typescript-iq-test-unitt-master-1 and searching for 1 tests
    amazon-ebs:
    amazon-ebs:             stderr:
2020/09/02 09:20:37 packer-builder-amazon-ebs plugin: [ERROR] Remote command exited with '2': /tmp/script_6663.sh  --branch master
2020/09/02 09:20:37 packer-builder-amazon-ebs plugin: [INFO] RPC endpoint: Communicator ended with: 2
2020/09/02 09:20:37 [INFO] 3256829 bytes written for 'stdout'
2020/09/02 09:20:37 [INFO] 80097 bytes written for 'stderr'
2020/09/02 09:20:37 [INFO] RPC client: Communicator ended with: 2
2020/09/02 09:20:37 [INFO] RPC endpoint: Communicator ended with: 2
2020/09/02 09:20:37 packer-provisioner-shell plugin: [INFO] 80097 bytes written for 'stderr'
==> amazon-ebs: make: *** [test-quickstarter] Error 1
    amazon-ebs:             err: exit status 1
    amazon-ebs:     --- PASS: TestQuickstarter/docker-plain (233.00s)
    amazon-ebs:     --- PASS: TestQuickstarter/ds-jupyter-notebook (373.11s)
    amazon-ebs:     --- PASS: TestQuickstarter/ds-ml-service (481.01s)
    amazon-ebs:     --- PASS: TestQuickstarter/ds-rshiny (968.33s)
    amazon-ebs:     --- FAIL: TestQuickstarter/e2e-cypress (232.96s)
    amazon-ebs:         quickstarter_test.go:241: Jenkins stages mismatch (-want +got):
    amazon-ebs:               (
    amazon-ebs:                   """
    amazon-ebs:                   ... // 5 identical lines
    amazon-ebs:                     {
    amazon-ebs:                       "stage": "Integration Test",
    amazon-ebs:             -         "status": "SUCCESS"
    amazon-ebs:             +         "status": "FAILED"
    amazon-ebs:                     },
    amazon-ebs:                     {
    amazon-ebs:             -         "stage": "SonarQube Analysis",
    amazon-ebs:             -         "status": "SUCCESS"
    amazon-ebs:             -       },
    amazon-ebs:             -       {
    amazon-ebs:             -         "stage": "odsPipeline finished",
    amazon-ebs:             -         "status": "SUCCESS"
    amazon-ebs:             +         "stage": "odsPipeline error",
    amazon-ebs:             +         "status": "FAILED"
    amazon-ebs:                     }
    amazon-ebs:                   ]
    amazon-ebs:                   """
    amazon-ebs:               )

Additional context Add any other context about the problem here.

michaelsauter commented 4 years ago

@georgfedermann Any chance to get those logs out of the machine? If not, that is something we should add to our list. Should be easy to know what the issue is when one sees the Jenkins log.

As there is no change I'm aware of, I guess some kind of JS dependency issue. @herrkoch @cschweikert would one of you be able to look into this - by running the cypress test in our cluster?

georgfedermann commented 4 years ago

@michaelsauter I'll run a manual build and will post the logs here as soon as available.

clemensutschig commented 4 years ago

Maybe it's a "latest" version of cypress topic? .. just thinking out loud .. or some weird version incompatibility.

clemensutschig commented 4 years ago

@michaelsauter - we should be able to dump the jenkins run log (the script is there) in case of a test error?

michaelsauter commented 4 years ago

@clemensutschig Yes, that's what I meant with "If not, that is something we should add to our list." .. just terribly worded :) I added a feature request at #796.

herrkoch commented 4 years ago

Hi, I can add to this that I recently updated dependencies in the Cypress quickstarter. The Jenkins build of my provisioned Cypress quickstarter ran fine in my OpenShift playground. I haven't seen the tests described here though, not sure how to execute these and where they can be found.

michaelsauter commented 4 years ago

@herrkoch See https://github.com/opendevstack/ods-core/tree/master/tests#ods-core---tests. Your reps changes sound unrelated because it has worked between then and this Tuesday.

georgfedermann commented 4 years ago

@michaelsauter here is the Jenkins log output for the failing cypress build unitt-cd/run-unitt-cypress-unitt-master

OpenShift Build unitt-cd/run-unitt-cypress-unitt-master-1 from http://bitbucket.odsbox.lan:7990/scm/unitt/unitt-cypress.git
Checking out git http://bitbucket.odsbox.lan:7990/scm/unitt/unitt-cypress.git into /var/lib/jenkins/jobs/unitt-cd/jobs/unitt-cd-run-unitt-cypress-unitt-master/workspace@script to read Jenkinsfile
using credential unitt-cd-cd-user-with-password
Cloning the remote Git repository
Cloning repository http://bitbucket.odsbox.lan:7990/scm/unitt/unitt-cypress.git
 > git init /var/lib/jenkins/jobs/unitt-cd/jobs/unitt-cd-run-unitt-cypress-unitt-master/workspace@script # timeout=10
Fetching upstream changes from http://bitbucket.odsbox.lan:7990/scm/unitt/unitt-cypress.git
 > git --version # timeout=10
using GIT_ASKPASS to set credentials unitt-cd-cd-user-with-password
 > git fetch --tags --progress http://bitbucket.odsbox.lan:7990/scm/unitt/unitt-cypress.git +refs/heads/*:refs/remotes/origin/*
 > git config remote.origin.url http://bitbucket.odsbox.lan:7990/scm/unitt/unitt-cypress.git # timeout=10
 > git config --add remote.origin.fetch +refs/heads/*:refs/remotes/origin/* # timeout=10
 > git config remote.origin.url http://bitbucket.odsbox.lan:7990/scm/unitt/unitt-cypress.git # timeout=10
Fetching upstream changes from http://bitbucket.odsbox.lan:7990/scm/unitt/unitt-cypress.git
using GIT_ASKPASS to set credentials unitt-cd-cd-user-with-password
 > git fetch --tags --progress http://bitbucket.odsbox.lan:7990/scm/unitt/unitt-cypress.git +refs/heads/*:refs/remotes/origin/*
 > git rev-parse origin/master^{commit} # timeout=10
Checking out Revision 56de6fe4855aac9e962dd71504d3b9121d140e39 (origin/master)
 > git config core.sparsecheckout # timeout=10
 > git checkout -f 56de6fe4855aac9e962dd71504d3b9121d140e39
Commit message: "Initial OpenDevStack commit"
First time build. Skipping changelog.
Running in Durability level: MAX_SURVIVABILITY
Loading library ods-jenkins-shared-library@master
Attempting to resolve master from remote references...
 > git --version # timeout=10
using GIT_ASKPASS to set credentials unitt-cd-cd-user-with-password
 > git ls-remote -h http://bitbucket.odsbox.lan:7990/scm/opendevstack/ods-jenkins-shared-library.git # timeout=10
Found match: refs/heads/master revision 85c44b82663389ee8438ec552cec05de22d0c715
using credential unitt-cd-cd-user-with-password
Cloning the remote Git repository
Cloning with configured refspecs honoured and without tags
Cloning repository http://bitbucket.odsbox.lan:7990/scm/opendevstack/ods-jenkins-shared-library.git
 > git init /var/lib/jenkins/jobs/unitt-cd/jobs/unitt-cd-run-unitt-cypress-unitt-master/workspace@libs/ods-jenkins-shared-library # timeout=10
Fetching upstream changes from http://bitbucket.odsbox.lan:7990/scm/opendevstack/ods-jenkins-shared-library.git
 > git --version # timeout=10
using GIT_ASKPASS to set credentials unitt-cd-cd-user-with-password
 > git fetch --no-tags --progress http://bitbucket.odsbox.lan:7990/scm/opendevstack/ods-jenkins-shared-library.git +refs/heads/*:refs/remotes/origin/*
 > git config remote.origin.url http://bitbucket.odsbox.lan:7990/scm/opendevstack/ods-jenkins-shared-library.git # timeout=10
 > git config --add remote.origin.fetch +refs/heads/*:refs/remotes/origin/* # timeout=10
 > git config remote.origin.url http://bitbucket.odsbox.lan:7990/scm/opendevstack/ods-jenkins-shared-library.git # timeout=10
Fetching without tags
Fetching upstream changes from http://bitbucket.odsbox.lan:7990/scm/opendevstack/ods-jenkins-shared-library.git
using GIT_ASKPASS to set credentials unitt-cd-cd-user-with-password
 > git fetch --no-tags --progress http://bitbucket.odsbox.lan:7990/scm/opendevstack/ods-jenkins-shared-library.git +refs/heads/*:refs/remotes/origin/*
Checking out Revision 85c44b82663389ee8438ec552cec05de22d0c715 (master)
 > git config core.sparsecheckout # timeout=10
 > git checkout -f 85c44b82663389ee8438ec552cec05de22d0c715
Commit message: "Add comment about image field"
First time build. Skipping changelog.
[Pipeline] Start of Pipeline
[Pipeline] node
Running on Jenkins in /var/lib/jenkins/jobs/unitt-cd/jobs/unitt-cd-run-unitt-cypress-unitt-master/workspace
[Pipeline] {
[Pipeline] sh
WARNING: Unknown parameter(s) found for class type 'org.jenkinsci.plugins.workflow.steps.durable_task.ShellStep': label
+ git config --get remote.origin.url
[Pipeline] sh
WARNING: Unknown parameter(s) found for class type 'org.jenkinsci.plugins.workflow.steps.durable_task.ShellStep': label
+ oc -n unitt-cd get bc/run-unitt-cypress-unitt-master -o 'jsonpath={.spec.source.git.uri}'
[Pipeline] }
[Pipeline] // node
[Pipeline] echo
[cypress] ***** Starting ODS Component Pipeline *****
[Pipeline] echo
***** Continuing on node 'master' *****
[Pipeline] node
Running on Jenkins in /var/lib/jenkins/jobs/unitt-cd/jobs/unitt-cd-run-unitt-cypress-unitt-master/workspace
[Pipeline] {
[Pipeline] wrap
[Pipeline] {
[Pipeline] checkout
using credential unitt-cd-cd-user-with-password
Cloning the remote Git repository
Cloning repository http://bitbucket.odsbox.lan:7990/scm/unitt/unitt-cypress.git
 > git init /var/lib/jenkins/jobs/unitt-cd/jobs/unitt-cd-run-unitt-cypress-unitt-master/workspace # timeout=10
Fetching upstream changes from http://bitbucket.odsbox.lan:7990/scm/unitt/unitt-cypress.git
 > git --version # timeout=10
using GIT_ASKPASS to set credentials unitt-cd-cd-user-with-password
 > git fetch --tags --progress http://bitbucket.odsbox.lan:7990/scm/unitt/unitt-cypress.git +refs/heads/*:refs/remotes/origin/*
 > git config remote.origin.url http://bitbucket.odsbox.lan:7990/scm/unitt/unitt-cypress.git # timeout=10
 > git config --add remote.origin.fetch +refs/heads/*:refs/remotes/origin/* # timeout=10
 > git config remote.origin.url http://bitbucket.odsbox.lan:7990/scm/unitt/unitt-cypress.git # timeout=10
Fetching upstream changes from http://bitbucket.odsbox.lan:7990/scm/unitt/unitt-cypress.git
using GIT_ASKPASS to set credentials unitt-cd-cd-user-with-password
 > git fetch --tags --progress http://bitbucket.odsbox.lan:7990/scm/unitt/unitt-cypress.git +refs/heads/*:refs/remotes/origin/*
 > git rev-parse origin/master^{commit} # timeout=10
Checking out Revision 56de6fe4855aac9e962dd71504d3b9121d140e39 (origin/master)
 > git config core.sparsecheckout # timeout=10
 > git checkout -f 56de6fe4855aac9e962dd71504d3b9121d140e39
Commit message: "Initial OpenDevStack commit"
[Pipeline] stage
[Pipeline] { (odsPipeline start)
[Pipeline] sh
WARNING: Unknown parameter(s) found for class type 'org.jenkinsci.plugins.workflow.steps.durable_task.ShellStep': label
+ env
+ grep ods.build.
+ true
[Pipeline] sh
WARNING: Unknown parameter(s) found for class type 'org.jenkinsci.plugins.workflow.steps.durable_task.ShellStep': label
+ env
+ grep library.ods-jenkins-shared-library.version
+ cut -d= -f2
[Pipeline] sh
WARNING: Unknown parameter(s) found for class type 'org.jenkinsci.plugins.workflow.steps.durable_task.ShellStep': label
+ git config --get remote.origin.url
[Pipeline] sh
WARNING: Unknown parameter(s) found for class type 'org.jenkinsci.plugins.workflow.steps.durable_task.ShellStep': label
+ oc get bc/run-unitt-cypress-unitt-master -n unitt-cd -o 'jsonpath={.spec.source.git.ref}'
[Pipeline] sh
WARNING: Unknown parameter(s) found for class type 'org.jenkinsci.plugins.workflow.steps.durable_task.ShellStep': label
+ git rev-parse HEAD
[Pipeline] sh
WARNING: Unknown parameter(s) found for class type 'org.jenkinsci.plugins.workflow.steps.durable_task.ShellStep': label
+ git --no-pager show -s '--format=%an (%ae)' HEAD
[Pipeline] sh
WARNING: Unknown parameter(s) found for class type 'org.jenkinsci.plugins.workflow.steps.durable_task.ShellStep': label
+ git log -1 --pretty=%B HEAD
[Pipeline] sh
WARNING: Unknown parameter(s) found for class type 'org.jenkinsci.plugins.workflow.steps.durable_task.ShellStep': label
+ git show -s --format=%ci HEAD
[Pipeline] sh
WARNING: Unknown parameter(s) found for class type 'org.jenkinsci.plugins.workflow.steps.durable_task.ShellStep': label
+ oc project dev
[Pipeline] }
[Pipeline] // stage
[Pipeline] sh
WARNING: Unknown parameter(s) found for class type 'org.jenkinsci.plugins.workflow.steps.durable_task.ShellStep': label
+ git show --pretty=%s%b -s
[Pipeline] }
[Pipeline] // wrap
[Pipeline] }
[Pipeline] // node
[Pipeline] echo
***** Continuing on node 'pod-a02da95b-1f58-4c2c-8e1e-471b0ab6ec31' based on image 'docker-registry.default.svc:5000/ods/jenkins-agent-nodejs10-angular:latest' *****
[Pipeline] podTemplate
[Pipeline] {
[Pipeline] node
Still waiting to schedule task
‘Jenkins’ doesn’t have label ‘pod-a02da95b-1f58-4c2c-8e1e-471b0ab6ec31’
Agent pod-a02da95b-1f58-4c2c-8e1e-471b0ab6ec31-31zkg-bzf75 is provisioned from template Kubernetes Pod Template
---
apiVersion: "v1"
kind: "Pod"
metadata:
  annotations:
    buildUrl: "http://jenkins.unitt-cd.svc:80/job/unitt-cd/job/unitt-cd-run-unitt-cypress-unitt-master/1/"
  labels:
    jenkins: "slave"
    jenkins/pod-a02da95b-1f58-4c2c-8e1e-471b0ab6ec31: "true"
  name: "pod-a02da95b-1f58-4c2c-8e1e-471b0ab6ec31-31zkg-bzf75"
spec:
  containers:
  - args:
    - "********"
    - "pod-a02da95b-1f58-4c2c-8e1e-471b0ab6ec31-31zkg-bzf75"
    env:
    - name: "JENKINS_SECRET"
      value: "********"
    - name: "JENKINS_TUNNEL"
      value: "jenkins-jnlp.unitt-cd.svc:50000"
    - name: "JENKINS_AGENT_NAME"
      value: "pod-a02da95b-1f58-4c2c-8e1e-471b0ab6ec31-31zkg-bzf75"
    - name: "JENKINS_NAME"
      value: "pod-a02da95b-1f58-4c2c-8e1e-471b0ab6ec31-31zkg-bzf75"
    - name: "JENKINS_AGENT_WORKDIR"
      value: "/tmp"
    - name: "JENKINS_URL"
      value: "http://jenkins.unitt-cd.svc:80/"
    - name: "HOME"
      value: "/home/jenkins"
    image: "docker-registry.default.svc:5000/ods/jenkins-agent-nodejs10-angular:latest"
    imagePullPolicy: "Always"
    name: "jnlp"
    resources:
      limits:
        memory: "2Gi"
        cpu: "1"
      requests:
        memory: "1Gi"
        cpu: "100m"
    securityContext:
      privileged: false
    tty: false
    volumeMounts:
    - mountPath: "/tmp"
      name: "workspace-volume"
      readOnly: false
    workingDir: "/tmp"
  nodeSelector: {}
  restartPolicy: "Never"
  serviceAccount: "jenkins"
  volumes:
  - emptyDir: {}
    name: "workspace-volume"

Running on pod-a02da95b-1f58-4c2c-8e1e-471b0ab6ec31-31zkg-bzf75 in /tmp/workspace/unitt-cd/unitt-cd-run-unitt-cypress-unitt-master
[Pipeline] {
[Pipeline] withCredentials
Masking supported pattern matches of $USERNAME or $TOKEN
[Pipeline] {
[Pipeline] }
[Pipeline] // withCredentials
[Pipeline] withCredentials
Masking supported pattern matches of $USERNAME or $TOKEN
[Pipeline] {
[Pipeline] sh
WARNING: Unknown parameter(s) found for class type 'org.jenkinsci.plugins.workflow.steps.durable_task.ShellStep': label
+ curl --fail --silent --request POST --header 'Authorization: Bearer ****' --header 'Content-Type: application/json' --data '{"state":"INPROGRESS","key":"56de6fe4","name":"56de6fe4","url":"https://jenkins-unitt-cd.ocp.odsbox.lan/job/unitt-cd/job/unitt-cd-run-unitt-cypress-unitt-master/1/"}' http://bitbucket.odsbox.lan:7990/rest/build-status/1.0/commits/56de6fe4855aac9e962dd71504d3b9121d140e39
[Pipeline] }
[Pipeline] // withCredentials
[Pipeline] wrap
[Pipeline] {
[Pipeline] sh
WARNING: Unknown parameter(s) found for class type 'org.jenkinsci.plugins.workflow.steps.durable_task.ShellStep': label
+ git lfs
[Pipeline] checkout
using credential unitt-cd-cd-user-with-password
Cloning the remote Git repository
Checking out Revision 56de6fe4855aac9e962dd71504d3b9121d140e39 (detached)
Enabling Git LFS pull
Cloning repository http://bitbucket.odsbox.lan:7990/scm/unitt/unitt-cypress.git
 > git init /tmp/workspace/unitt-cd/unitt-cd-run-unitt-cypress-unitt-master # timeout=10
Fetching upstream changes from http://bitbucket.odsbox.lan:7990/scm/unitt/unitt-cypress.git
 > git --version # timeout=10
using GIT_ASKPASS to set credentials unitt-cd-cd-user-with-password
 > git fetch --tags --progress http://bitbucket.odsbox.lan:7990/scm/unitt/unitt-cypress.git +refs/heads/*:refs/remotes/origin/*
 > git config remote.origin.url http://bitbucket.odsbox.lan:7990/scm/unitt/unitt-cypress.git # timeout=10
 > git config --add remote.origin.fetch +refs/heads/*:refs/remotes/origin/* # timeout=10
 > git config remote.origin.url http://bitbucket.odsbox.lan:7990/scm/unitt/unitt-cypress.git # timeout=10
Fetching upstream changes from http://bitbucket.odsbox.lan:7990/scm/unitt/unitt-cypress.git
using GIT_ASKPASS to set credentials unitt-cd-cd-user-with-password
 > git fetch --tags --progress http://bitbucket.odsbox.lan:7990/scm/unitt/unitt-cypress.git +refs/heads/*:refs/remotes/origin/*
 > git rev-parse 56de6fe4855aac9e962dd71504d3b9121d140e39^{commit} # timeout=10
 > git config core.sparsecheckout # timeout=10
 > git checkout -f 56de6fe4855aac9e962dd71504d3b9121d140e39
 > git config --get remote.origin.url # timeout=10
using GIT_ASKPASS to set credentials unitt-cd-cd-user-with-password
 > git lfs pull origin
Commit message: "Initial OpenDevStack commit"
[Pipeline] stage
[Pipeline] { (Integration Test)
[Pipeline] sh
WARNING: Unknown parameter(s) found for class type 'org.jenkinsci.plugins.workflow.steps.durable_task.ShellStep': label
+ oc -n unitt-dev create route edge test-route-1599132330188 --service=dummy --port=80
+ true
[Pipeline] sh
WARNING: Unknown parameter(s) found for class type 'org.jenkinsci.plugins.workflow.steps.durable_task.ShellStep': label
+ oc -n unitt-dev get route test-route-1599132330188 -o 'jsonpath={.spec.host}'
[Pipeline] sh
WARNING: Unknown parameter(s) found for class type 'org.jenkinsci.plugins.workflow.steps.durable_task.ShellStep': label
+ oc -n unitt-dev delete route test-route-1599132330188
+ true
[Pipeline] withEnv
[Pipeline] {
[Pipeline] sh
+ npm install
npm WARN deprecated har-validator@5.1.5: this library is no longer supported

> cypress@5.1.0 postinstall /tmp/workspace/unitt-cd/unitt-cd-run-unitt-cypress-unitt-master/node_modules/cypress
> node index.js --exec install

Installing Cypress (version: 5.1.0)

[?25l[11:25:52]  Downloading Cypress     [started]
[11:25:56]  Downloading Cypress     [completed]
[11:25:56]  Unzipping Cypress       [started]
[11:26:20]  Unzipping Cypress       [completed]
[11:26:20]  Finishing Installation  [started]
[11:26:20]  Finishing Installation  [completed]
[?25h
You can now open Cypress by running: node_modules/.bin/cypress open

https://on.cypress.io/installing-cypress

[?25hnpm notice created a lockfile as package-lock.json. You should commit this file.
added 311 packages from 278 contributors in 49.293s

24 packages are looking for funding
  run `npm fund` for details

[Pipeline] sh
+ npm run e2e

> e2e@0.0.0 e2e /tmp/workspace/unitt-cd/unitt-cd-run-unitt-cypress-unitt-master
> npm-run-all lint build delete-junit-results cypress:run-installation cypress:run-integration cypress:run-acceptance

> e2e@0.0.0 lint /tmp/workspace/unitt-cd/unitt-cd-run-unitt-cypress-unitt-master
> tslint --project .

/tmp/workspace/unitt-cd/unitt-cd-run-unitt-cypress-unitt-master/node_modules/cypress/types/net-stubbing.ts:7:15
ERROR: 7:15    semicolon           Missing semicolon
ERROR: 8:39    semicolon           Missing semicolon
ERROR: 9:16    semicolon           Missing semicolon
ERROR: 10:20   semicolon           Missing semicolon
ERROR: 11:25   semicolon           Missing semicolon
ERROR: 17:4    semicolon           Missing semicolon
ERROR: 23:59   unified-signatures  This overload and the one on line 29 can be combined into one signature with an optional parameter.
ERROR: 24:33   unified-signatures  This overload and the one on line 29 can be combined into one signature with an optional parameter.
ERROR: 25:10   unified-signatures  This overload and the one on line 29 can be combined into one signature with an optional parameter.
ERROR: 33:5    member-ordering     Declaration of instance field not allowed after declaration of instance method. Instead, this should come at the beginning of the class/interface.
ERROR: 37:5    member-ordering     Declaration of instance field not allowed after declaration of instance method. Instead, this should come at the beginning of the class/interface.
ERROR: 38:4    semicolon           Missing semicolon
ERROR: 42:4    semicolon           Missing semicolon
ERROR: 45:20   semicolon           Missing semicolon
ERROR: 46:72   semicolon           Missing semicolon
ERROR: 47:76   semicolon           Missing semicolon
ERROR: 48:93   semicolon           Missing semicolon
ERROR: 49:57   semicolon           Missing semicolon
ERROR: 54:19   semicolon           Missing semicolon
ERROR: 60:33   semicolon           Missing semicolon
ERROR: 62:103  semicolon           Missing semicolon
ERROR: 64:124  semicolon           Missing semicolon
ERROR: 69:46   semicolon           Missing semicolon
ERROR: 75:13   semicolon           Missing semicolon
ERROR: 77:11   semicolon           Missing semicolon
ERROR: 78:42   semicolon           Missing semicolon
ERROR: 83:25   semicolon           Missing semicolon
ERROR: 84:45   semicolon           Missing semicolon
ERROR: 86:44   semicolon           Missing semicolon
ERROR: 91:26   semicolon           Missing semicolon
ERROR: 93:22   semicolon           Missing semicolon
ERROR: 102:12  semicolon           Missing semicolon
ERROR: 105:17  semicolon           Missing semicolon
ERROR: 106:11  semicolon           Missing semicolon
ERROR: 107:31  semicolon           Missing semicolon
ERROR: 108:24  semicolon           Missing semicolon
ERROR: 109:19  semicolon           Missing semicolon
ERROR: 110:39  semicolon           Missing semicolon
ERROR: 113:49  semicolon           Missing semicolon
ERROR: 118:63  semicolon           Missing semicolon
ERROR: 121:29  semicolon           Missing semicolon
ERROR: 124:76  semicolon           Missing semicolon
ERROR: 130:38  semicolon           Missing semicolon
ERROR: 134:27  semicolon           Missing semicolon
ERROR: 138:15  semicolon           Missing semicolon
ERROR: 142:18  semicolon           Missing semicolon
ERROR: 146:13  semicolon           Missing semicolon
ERROR: 150:11  semicolon           Missing semicolon
ERROR: 154:15  semicolon           Missing semicolon
ERROR: 158:23  semicolon           Missing semicolon
ERROR: 162:25  semicolon           Missing semicolon
ERROR: 166:10  semicolon           Missing semicolon
ERROR: 169:60  semicolon           Missing semicolon
ERROR: 171:85  semicolon           Missing semicolon
ERROR: 176:76  semicolon           Missing semicolon
ERROR: 182:20  semicolon           Missing semicolon
ERROR: 186:14  semicolon           Missing semicolon
ERROR: 190:38  semicolon           Missing semicolon
ERROR: 194:22  semicolon           Missing semicolon
ERROR: 196:1   max-line-length     Exceeds maximum line length of 140
ERROR: 198:30  semicolon           Missing semicolon
ERROR: 204:49  semicolon           Missing semicolon
ERROR: 209:74  semicolon           Missing semicolon
ERROR: 210:90  semicolon           Missing semicolon

npm ERR! code ELIFECYCLE
npm ERR! errno 2
npm ERR! e2e@0.0.0 lint: `tslint --project .`
npm ERR! Exit status 2
npm ERR! 
npm ERR! Failed at the e2e@0.0.0 lint script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in:
npm ERR!     /home/jenkins/.npm/_logs/2020-09-03T11_26_31_418Z-debug.log
ERROR: "lint" exited with 2.
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! e2e@0.0.0 e2e: `npm-run-all lint build delete-junit-results cypress:run-installation cypress:run-integration cypress:run-acceptance`
npm ERR! Exit status 1
npm ERR! 
npm ERR! Failed at the e2e@0.0.0 e2e script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in:
npm ERR!     /home/jenkins/.npm/_logs/2020-09-03T11_26_31_463Z-debug.log
[Pipeline] junit
Recording test results
None of the test reports contained any result
[Pipeline] stash
Stashed 0 file(s)
[Pipeline] stash
Stashed 0 file(s)
[Pipeline] stash
Stashed 0 file(s)
[Pipeline] error
[Pipeline] }
[Pipeline] // withEnv
[Pipeline] }
[Pipeline] // stage
[Pipeline] }
[Pipeline] // wrap
[Pipeline] stage
[Pipeline] { (odsPipeline error)
[Pipeline] echo
WARN: [cypress] ***** Finished ODS Pipeline for cypress (with error) ***** (took 100585 ms)
[Pipeline] echo
WARN: Error: hudson.AbortException: Executing tests failed!
[Pipeline] withCredentials
Masking supported pattern matches of $USERNAME or $TOKEN
[Pipeline] {
[Pipeline] sh
WARNING: Unknown parameter(s) found for class type 'org.jenkinsci.plugins.workflow.steps.durable_task.ShellStep': label
+ curl --fail --silent --request POST --header 'Authorization: Bearer ****' --header 'Content-Type: application/json' --data '{"state":"FAILED","key":"56de6fe4","name":"56de6fe4","url":"https://jenkins-unitt-cd.ocp.odsbox.lan/job/unitt-cd/job/unitt-cd-run-unitt-cypress-unitt-master/1/"}' http://bitbucket.odsbox.lan:7990/rest/build-status/1.0/commits/56de6fe4855aac9e962dd71504d3b9121d140e39
[Pipeline] }
[Pipeline] // withCredentials
[Pipeline] emailextrecipients
[Pipeline] emailext
An attempt to send an e-mail to empty list of recipients, ignored.
[Pipeline] }
[Pipeline] // stage
[Pipeline] echo
Attempting to stash testresults from location: 'build/test-results/test'
[Pipeline] sh
WARNING: Unknown parameter(s) found for class type 'org.jenkinsci.plugins.workflow.steps.durable_task.ShellStep': label
+ mkdir -p build/test-results/test build/test-results/test
+ cp -rf 'build/test-results/test/*' build/test-results/test
+ true
cp: cannot stat 'build/test-results/test/*': No such file or directory
[Pipeline] sh
WARNING: Unknown parameter(s) found for class type 'org.jenkinsci.plugins.workflow.steps.durable_task.ShellStep': label
+ ls -la 'build/test-results/test/*.xml'
+ wc -l
ls: cannot access build/test-results/test/*.xml: No such file or directory
[Pipeline] echo
No xUnit results found!!
[Pipeline] }
[Pipeline] // node
[Pipeline] }
[Pipeline] // podTemplate
[Pipeline] End of Pipeline
ERROR: Executing tests failed!
Finished: FAILURE
herrkoch commented 4 years ago

Hmm really strange, it is throwing linting errors for a file inside node_modules even though the node_modules folder should be skipped by tslint by default.

clemensutschig commented 4 years ago

interesting indeed ... is there some flag to exclude this?

cschweikert commented 4 years ago

I guess the reason is this line: https://github.com/opendevstack/ods-quickstarters/blob/a21cf1938e7ab549377458dc816737e96a8f9ca0/e2e-cypress/files/tsconfig.json#L6 This might include the folder with the cypress types folder into the linting.

clemensutschig commented 4 years ago

@cschweikert - what's weird is that we lock the version ... was there an update yesterday against cypress types?

cschweikert commented 4 years ago

Could have been introduced by this change 14 days ago: https://github.com/opendevstack/ods-quickstarters/commit/823f86f515846e64d0aa72f6af64ebd8a041a106

clemensutschig commented 4 years ago

@cschweikert - this worked until yesterday? .. is there something screwed up in the pkg json?

herrkoch commented 4 years ago

Good catch @cschweikert. I was able to reproduce the issue and found the cause: In the quickstarter we have no package-lock.json checked in and the Cypress version is specified with "cypress": "^5.0.0" so it updated to 5.1.0 which introduced this file with linting errors, so somewhat a "breaking change" for us. After removing the node_modules include from the tsconfig, it's working fine again (no idea why it was added there in the first place).

herrkoch commented 4 years ago

I will provide a PR. Should I additionally fix the dependencies in the package.json to a specific minor version or continue to have the ^ to get compatible updates in (which I usually like, I think it was an exception this time)?

cschweikert commented 4 years ago

It could be, that this line is needed for having proper typing support. Maybe it make sense to test with an IDE like vscode, if code completion is still working for cy. ... commands. Please don't forget to restart the ts language server (or the IDE) after making a change to tsconfig.json.

cschweikert commented 4 years ago

I guess it is also fine to point to "5.1.0" or something directly. Since there is no package-lock.json...

herrkoch commented 4 years ago

Thanks for the hint @cschweikert, I checked with my IntelliJ IDEA, at least there auto-completion still worked after removing the include. I just asked live in the frontend community call what they prefer for the quickstarter to have, fixed dependencies with ~ or allow minor version differences between different provisioned quickstarters with the more lenient ^, and they voted for the latter, so I kept it that way. 😄