search

opendevstack / ods-core

The core of OpenDevStack - infrastructure setup based on Atlassian tools, Jenkins, Nexus, SonarQube and shared images
Apache License 2.0
47 stars 34 forks source link

Extend ods-core automated tests to check prov app CM QS config against ods-quickstarters/quickstarters #804

Open clemensutschig opened 4 years ago

clemensutschig commented 4 years ago

based on #800

Is your feature request related to a problem? Please describe. See related bug, we have currently no automated way to check if the quickstarter config for prov app (in: https://github.com/opendevstack/ods-core/blob/master/ods-provisioning-app/ocp-config/cm.yml#L291-L343) matches really existing quickstarters (https://github.com/opendevstack/ods-quickstarters)

Describe the solution you'd like Automated test verification

@segator

clemensutschig commented 4 years ago

@michaelsauter as the test framework already expects a deployed ods ... we could easily verify that there is corresponding entry in the config map?! ... 

$ oc get cm quickstarters.properties -o 'jsonpath={.data.properties}'
segator commented 4 years ago

is good idea, but i prefer if ods-test uses prov-app to create quickstarter instead of bypass like is doing now and execute directly webhook-proxy, we are skiping an important building block of the system.

clemensutschig commented 4 years ago

we have a test that does all this,... the idea to go the quickest route and test as much functionality - if I am not mistaken - this was the only issue that was found, or?

michaelsauter commented 4 years ago

Most tests should not go via prov app. Most tests should touch as few systems as possible.

There is a test that does integration end-to-end, which does create a project and a quickstarter.