search

opendevstack / ods-documentation

Antora playbooks to generate the versioned documentation
0 stars 6 forks source link

[feature request]: search only in selected version #41

Open SimonGolms opened 4 years ago

SimonGolms commented 4 years ago

I welcome the implementation of a search bar with PR #29. Unfortunately, it shows all results from all versions. As an end user I would have expected to see only the results from my selected version, which is per default the latest.

image

tbugfinder commented 4 years ago

https://github.com/opendevstack/ods-documentation/pull/59

tbugfinder commented 4 years ago

@michaelsauter just curious - above screenshot includes "Components" at top right. Is this needed as it seems to be lost, too.

tbugfinder commented 4 years ago
image
michaelsauter commented 4 years ago

@tbugfinder No, the "components" bit was due to how the docs were organised prior to 2.x. Back then, all was categorised by repo, which is not ideal as for the user the repo structure doesn't really matter. Now we are free to organise the docs in any structure we think is most helpful.

michaelsauter commented 4 years ago

Partially solved by #59. I'd still leave this issue open because a "search in selected version" would be the best default IMHO.

tbugfinder commented 4 years ago

I don't think this is feasible right now comparing to antora or couchbase search result pages. IMHO, grouping would be sufficient.

tbugfinder commented 2 years ago

In development https://gitlab.com/antora/antora-lunr-extension/-/issues/51