Open michaelsauter opened 3 years ago
I think it's dead code (as we somewhere default the type to ods
from what I remember ... )
// Set repo type, if not provided
if (!repo.type?.trim()) {
repo.type = MROPipelineUtil.PipelineConfig.REPO_TYPE_ODS_CODE
}
so we should introduce makefile
and shellscript
imho
You're right @michaelsauter. This stems from the first executor implementation which happened before the ods
type got integrated. Then, ods
became a default as indicated by @clemensutschig which rendered this block a dead code in the end. I would like to see this get revitalised ;-) but this would require a new component type that integrates with the Release Manager.
I've come across https://github.com/opendevstack/ods-jenkins-shared-library/blob/master/src/org/ods/orchestration/util/MROPipelineUtil.groovy#L343-L362.
That part is, to my understanding, only executed if the repo is not of type
ods
,ods-service
orods-test
(based on theif
conditions above). However, according to the docs (https://github.com/opendevstack/ods-jenkins-shared-library/blob/master/docs/modules/jenkins-shared-library/pages/orchestration-pipeline.adoc#configuration) there are only 3 repo types:ods
,ods-service
andods-test
.Which makes me wonder if the shell script / Makefile part is dead code and can be removed, or if there is an undocumented component type, or if I am just confused and don't understand the code.
@metmajer do you know more on this?