search

opendevstack / ods-jenkins-shared-library

Shared Jenkins library which all ODS projects & components use - provisioning, SonarQube code scanning, Nexus publishing, OpenShift template based deployments and repository orchestration
Apache License 2.0
70 stars 57 forks source link

Insufficient user input validation in library #897

Open serverhorror opened 2 years ago

serverhorror commented 2 years ago

When using the backslash character (\) in your git username that user input is not properly validated and leads to broken builds

This comes up when users are using their "qualified" Windows login name as their git author info, e.g.: FABRIKAM\\alice (alice@fabrikam.com)

To Reproduce Steps to reproduce the behavior:

  1. Set your git username to domain\\user
  2. commit
  3. push
  4. Jenkins build fails

Expected behavior

The Jenkins build should successfully continue. The username is only a string that should not cause the build to fail

Screenshots If applicable, add screenshots to help explain your problem.

Affected version (please complete the following information):

KMax commented 2 years ago

@serverhorror We had the issue in Openshift 3.x and OpenDevStack 4.x. I think your description of the issue is complete, I have nothing to add.