search

opendevstack / ods-jenkins-shared-library

Shared Jenkins library which all ODS projects & components use - provisioning, SonarQube code scanning, Nexus publishing, OpenShift template based deployments and repository orchestration
Apache License 2.0
75 stars 57 forks source link

Deployment rollout stage issues #957

Closed BraisVQ closed 1 year ago

BraisVQ commented 2 years ago

Describe the bug odsComponentStageRolloutOpenShiftDeployment makes the DeploymentConfig pause/resume in the process to update the resource. If the resources have been paused before and it try to pause it again or if the resource is not paused and it tries to resume it again the pipeline will fail. We have also seen that if the pipeline tries to rollout and the rollout is already running the pipeline will also fail.

To Reproduce Steps to reproduce the behavior:

  1. Run a component pipeline with the one of the 3 situations mentioned before
  2. See error

Expected behavior Pipeline should be able to handle these errors and the pipeline should complete

Screenshots

Rollout running and pipeline tries to trigger a rollout image

Deployment is not paused but pipeline tries to resume it image

Deployment is paused but pipeline tries to pause it image

Affected version:

metmajer commented 1 year ago

@braisvq1996 can the support team please prepare a PR?