opendevstack / ods-jenkins-shared-library

Shared Jenkins library which all ODS projects & components use - provisioning, SonarQube code scanning, Nexus publishing, OpenShift template based deployments and repository orchestration
Apache License 2.0
72 stars 57 forks source link

enhance customisation options for buildconfig #998

Open tbugfinder opened 1 year ago

tbugfinder commented 1 year ago

Is your feature request related to a problem? Please describe. It should be possible to configure buildconfig settings like the memory / cpu limits or buildfrom within odsComponentStageBuildOpenShiftImage. Currently a developer could tweak those settings once the buildconfig was deployed within an Openshift project.

It would also be beneficial to configure builds for build/execution speed.

Describe the solution you'd like Add an configuration option to odsComponentStageBuildOpenShiftImage.


spec:
  resources:
    limits:
      cpu: "1" 
      memory: "6Gi"
    requests:
      cpu: "200m"
      memory: "2Gi"

Describe alternatives you've considered

Additional context

I'm also wondering if the buildconfig couldn't default to e.g. 4 CPUs or 8 CPUs and 8Gi memory. This would improve developer experience a lot and it doesn't harm anything and shouldn't cost too much either in a cloud auto-scaling environment.

gerardcl commented 1 year ago

I also miss here the config option to set the buildFrom attribute, maybe we could switch this issue to "enhance customisation config options for build stage" ?

tbugfinder commented 1 year ago

Could you paste the link to docs and an example?

gerardcl commented 1 year ago

hi @tbugfinder ! sure!