search

opendevstack / ods-mro-jenkins-shared-library

CAUTION! This repo is DEPRECATED. For ODS 3+, please see ods-jenkins-shared-library repository.
Apache License 2.0
1 stars 4 forks source link

Fix git tag checkout and other things ... #150

Closed michaelsauter closed 4 years ago

michaelsauter commented 4 years ago

@clemensutschig With this, I can generate the documents now. I don't like it - but anything else I tried was blocked by some Jenkins bug eventually.

I also noticed that the TIP seems to contain wrong refs in terms of which Git ref is used for related repos. This does not use the actual value from repo.data, but seems to get what is in metadata.yml. I will look into this on Monday.

clemensutschig commented 4 years ago

9I Love it.. pull over my jenkins File.. and then close my pr.. whats up in the tip?

Did you also try deploy to qa?

Lets Touch Base monday to talk about the tip... in case of wip the branch is ok.. in case of Version it needs to contain the tag i believe

michaelsauter commented 4 years ago

@clemensutschig Okay, let's talk on Monday ... I'm done for the day.

Tests are fixed now except one, however that is purely a test setup issue.

Yes I deployed to QA, documents get generated but the tag is wrong as you saw too ...

michaelsauter commented 4 years ago

WARNING: I also changed the target to be master since now the feature/refactor-leva-docs has been merged to master!

michaelsauter commented 4 years ago

Related are fixes in the templates: https://github.com/opendevstack/ods-document-generation-templates/commit/8135adc1a98a1ad5f14dc21fc314e1c9db0ddb15 and https://github.com/opendevstack/ods-document-generation-templates/commit/3be0ba8e70209974ad7ef89c696cd0f81c674fdf.

michaelsauter commented 4 years ago

Another wording fix in the templates: https://github.com/opendevstack/ods-document-generation-templates/commit/2b10cf6.

michaelsauter commented 4 years ago

@clemensutschig @metmajer @martsec This is ready from my point of view. Documents generate - as far as I can tell - correctly for D/WIP, D/version, Q and P.

martsec commented 4 years ago

Related are fixes in the templates: opendevstack/ods-document-generation-templates@8135adc and opendevstack/ods-document-generation-templates@3be0ba8.

I've added your template changes to our internal repo so we can check-it out when merging this pr.

metmajer commented 4 years ago

@michaelsauter can't wait to have this in master. Can you please squash and merge asap (tomorrow morning)? Cheers!

clemensutschig commented 4 years ago

@michaelsauter - found one more - please do NOT merge ...

in case a quickstarter of type ods-test is added ... looks like the branch / tags are created in assembly mode, but appearently not, as the promotion fails

assemble:

spock:::: 
To ...... odsst-release-m.git
 * [new branch]      release/6 -> release/6
 * [new tag]         v6-UNDEFINED-0-D -> v6-UNDEFINED-0-D
[Pipeline] }
[Pipeline] // stage
[Pipeline] }

looks like the component is treated wrongly ... I looked at the logic below ..

https://github.com/opendevstack/ods-mro-jenkins-shared-library/blob/fix/git-tag-checkout/src/org/ods/util/MROPipelineUtil.groovy#L471-L477

and I don't get it ... we could tag and push in phase test ... maybe the directory we are in is wrong?

Found it - we don't wrap the steps with dir .. same for type shell script..