search

opendevstack / ods-pipeline-helm

ODS Pipeline tasks for Helm deployment
Apache License 2.0
0 stars 0 forks source link

ods-deploy-helm release-name is component not the chart-name #4

Open henrjk opened 1 year ago

henrjk commented 1 year ago

Currently the documentation at https://github.com/opendevstack/ods-pipeline/blob/master/docs/tasks/ods-deploy-helm.adoc states: "The Helm release name. If empty, the release name is simply the name of the chart."

However it actually defaults to the component name see https://github.com/opendevstack/ods-pipeline/blob/01a67e7a6a1dcb98045e73bbefc939cb854084c9/cmd/deploy-helm/steps.go#L86-L90

To me what is documented makes more sense but it should be consistent.

michaelsauter commented 10 months ago

Transferring as a consequence of https://github.com/opendevstack/ods-pipeline/pull/722.