opendevstack / ods-pipeline

Alternative ODS CI/CD pipeline based on Tekton / OpenShift Pipelines
Apache License 2.0
13 stars 5 forks source link

helm-diff does not distinguish between error and diff #583

Closed michaelsauter closed 2 years ago

michaelsauter commented 2 years ago

--detailed-exitcode returns exit code 1 for errors and exit code 2 for diff. We do not distinguish between those. As a consequence, if the diff cannot be created (exit code 1), an upgrade will be attempted. That upgrade is likely to fail. It would be better to explicitly stop the task when diff returns exit code 1. That said, the bug isn't too bad since it should likely not hurt to attempt an upgrade, it most likely won't work anyway.