opendevstack / ods-pipeline

Alternative ODS CI/CD pipeline based on Tekton / OpenShift Pipelines
Apache License 2.0
13 stars 5 forks source link

Add Node 18 image #585

Closed michaelsauter closed 1 year ago

michaelsauter commented 2 years ago

Related to https://github.com/opendevstack/ods-quickstarters/pull/795.

We can and should still support the Node 16 image, we'd only make 18 the new default in the task param.

@cschweikert something you could / want to contribute?

cschweikert commented 2 years ago

There is no nodejs version 18 available yet for ubi8 (registry.access.redhat.com/ubi8/nodejs-18 is missing). I guess we would need to wait for it. I'll check from time to time and when it is there I'd continue here.

michaelsauter commented 2 years ago

Oh I see. Yes then we need to wait. Same story for Go 1.18 ;) Thanks for checking regularly!

tbugfinder commented 2 years ago

How do you decide if an installation package has to come from RedHat or the nodejs/go packages are sufficient?

michaelsauter commented 2 years ago

At the moment, all base images in this repo are UBI images provided by RedHat. This makes maintenance simple and consistent. Typically I think waiting a few more weeks/months doesn't hurt anyone really. Also keep in mind that ODS pipeline is just Tekton, so you can anyway use any image you want by supplying your own task ... :)

michaelsauter commented 1 year ago

@cschweikert it is available now: https://catalog.redhat.com/software/containers/ubi8/nodejs-18/6278e5c078709f5277f26998 🎉