opendevstack / ods-pipeline

Alternative ODS CI/CD pipeline based on Tekton / OpenShift Pipelines
Apache License 2.0
13 stars 5 forks source link

branch to environment mapping did not work as expected #635

Closed henrjk closed 1 year ago

henrjk commented 1 year ago

With ods.yaml:

branchToEnvironmentMapping:
  - branch: 'dev'
    environment: dev
  - branch: 'task/PROJECT-1432-desc'
    environment: dev

....
pipeline:
  tasks:
    - name: deploy
      taskRef:
        kind: Task
        name: ods-deploy-helm-v0-7-0
      workspaces:
        - name: source
          workspace: shared-workspace

and pushing branch 'task/PROJECT-1432-desc' the deploy tasks log states this:

+ deploy-with-helm -chart-dir=./chart -release-name= -diff-flags=--three-way-merge '-upgrade-flags=--install --wait' -age-key-secret=helm-secrets-age-key
No environment to deploy to selected. Skipping deployment ...

The pipeline manager log shows this (slightly redacted):

2022-11-28T16:30:10Z | INFO | receiver: {Project:project Component:deploy Repository:project-deploy Stage:dev Environment: Version: GitRef:task/project-1432-desc GitFullRef:refs/heads/task/PROJECT-1432-desc GitSHA:a5d6839e4939f152c156c292df79dcee18a44f75 ...}

There is likely a problem with case sensitivity here as the deployment environment is found when having a wildcard in the branchToEnvironmentMapping like so:

branchToEnvironmentMapping:
  - branch: 'dev'
    environment: dev
  - branch: 'task/*'
    environment: dev
michaelsauter commented 1 year ago

This is not applicable anymore once #685 is merged.