This is a follow-up from #648. To make it easier to test #648 manually, we merged that before doing manual testing.
The issues addressed in this PR were not picked up in automated tests because:
when -private-cert is given, the tests clone from a server using the test private cert, but in manual testing the server was using a public cert (and only Nexus/SQ were using private certs). While debugging this issue I replaced the usage of Tekton's git-init with plain git, making it easier to debug what is going on and removing a dependency in the container image that is not really needed.
The md5 logic tests used the md5 binary, and the md5sum binary in the UBI images behaves differently than expected, I got that mixed up when I tried md5sum locally in an UBI image earlier.
The Gradle configure script was using some old paths, I assume I updated them after running the tests locally, and the GH tests do not actually execute the private cert path right now. Long-term we should enable this somehow.
Tasks:
[x] Updated design documents in docs/design directory or not applicable
[x] Updated user-facing documentation in docs directory or not applicable
This is a follow-up from #648. To make it easier to test #648 manually, we merged that before doing manual testing.
The issues addressed in this PR were not picked up in automated tests because:
-private-certis given, the tests clone from a server using the test private cert, but in manual testing the server was using a public cert (and only Nexus/SQ were using private certs). While debugging this issue I replaced the usage of Tekton'sgit-initwith plain git, making it easier to debug what is going on and removing a dependency in the container image that is not really needed.md5binary, and themd5sumbinary in the UBI images behaves differently than expected, I got that mixed up when I triedmd5sumlocally in an UBI image earlier.Tasks:
docs/designdirectory or not applicabledocsdirectory or not applicablemake test) or not applicable