search

opendevstack / ods-pipeline

Alternative ODS CI/CD pipeline based on Tekton / OpenShift Pipelines
Apache License 2.0
13 stars 5 forks source link

`deploy/install.sh` help page example is a bit misleading #667

Closed stevegbrooks closed 1 year ago

stevegbrooks commented 1 year ago

The help page for install.sh has an example where the namespace is given as "foo", but in reality one would always want to specify "foo-cd". If you agree, then I can do a PR to append "-cd" to the example for namespace.

@gerardcl

michaelsauter commented 1 year ago

Sure, happy to change the example to foo-cd.

However, it is just foo because there is actually no requirement for it to have a specific name, or the -cd suffix. This is in contrast to classic ODS which has those naming conventions hardcoded.

stevegbrooks commented 1 year ago

oh i see - i guess its just me that didn't understand it. if everyone else thinks its clear then no need to change!