opendevstack / ods-pipeline

Alternative ODS CI/CD pipeline based on Tekton / OpenShift Pipelines
Apache License 2.0
13 stars 5 forks source link

Task/remove local skopeo dependency #681

Closed henrjk closed 11 months ago

henrjk commented 1 year ago

At the moment this does not work, but I am not sure why. Tag related commands from log excerpt gh-issue-662-docker-tags-not-working.log:

INFO  | skopeo copy docker://kind-registry.kind:5000/npjhnsyo/workspace-280637196:3cd3a01e4f8924ae17e4273543b5d6739ce3dc32 docker://kind-registry.kind:5000/npjhnsyo/workspace-280637196:latest

INFO  | skopeo copy docker://kind-registry.kind:5000/npjhnsyo/workspace-280637196:3cd3a01e4f8924ae17e4273543b5d6739ce3dc32 docker://kind-registry.kind:5000/npjhnsyo/workspace-280637196:cool

And then the local test command:

ods-package-image_test.go:143: docker [inspect --format={{.RepoTags}} localhost:5000/npjhnsyo/workspace-280637196:3cd3a01e4f8924ae17e4273543b5d6739ce3dc32]: exit status 1

exit status 1 means that the image is not found.

Now when I comment out the checkTags invocation, run the test and then locally issue the command it does find the image and associated manifest:

$docker inspect --format={{.RepoTags}} localhost:5000/lmxlhpwy/workspace-2456216427:3507037f00154c62410142e770df87fbed35db20
[localhost:5000/lmxlhpwy/workspace-2456216427:3507037f00154c62410142e770df87fbed35db20 localhost:5000/lmxlhpwy/workspace-2456216427:cool localhost:5000/lmxlhpwy/workspace-2456216427:latest]

Closes opendevstack/ods-pipeline-image#4

Tasks:

michaelsauter commented 11 months ago

Closing as a consequence of https://github.com/opendevstack/ods-pipeline/pull/722. Unfortunately PRs cannot be transferred so a similar PR would need to be opened in ods-pipeline-image.