search

opendevstack / ods-pipeline

Alternative ODS CI/CD pipeline based on Tekton / OpenShift Pipelines
Apache License 2.0
13 stars 5 forks source link

Remove deprecated npm config definition `always-auth` #687

Closed henninggross closed 1 year ago

henninggross commented 1 year ago

When running the tasks test in GitHub actions we run into the following error when using the npm-node18-toolset:

npm ERR! `always-auth` is not a valid npm option

(more details here: https://github.com/opendevstack/ods-pipeline/actions/runs/4807341283/jobs/8557135297#step:16:2872)

The npm team removed the config definition always-auth with release v7.11.1 (changelog) and the node18 base image seems to now use a higher version than that.

We should remove the following line from the build script: https://github.com/opendevstack/ods-pipeline/blob/4a8716535d51acb099a81b6619c4c2f747896f77/build/package/scripts/build-npm.sh#L74

michaelsauter commented 1 year ago

The npm team removed the config definition always-auth with release v7.11.1 (changelog) and the node18 base image seems to now use a higher version than that.

Thanks Henning for figuring this out. Breaking change in a patch version ... no comment.

henninggross commented 1 year ago

Breaking change in a patch version ... no comment.

It seems to be a common theme with npm ... we might want to sponsor them a training in SemVer 😄