No lowercasing of branch to fix pipeline matching

opendevstack / ods-pipeline

Alternative ODS CI/CD pipeline based on Tekton / OpenShift Pipelines

Apache License 2.0

13 stars 5 forks source link

No lowercasing of branch to fix pipeline matching #714

Closed henrjk closed 1 year ago

henrjk commented 1 year ago

Fixes #713

Tasks:

[NA] Updated design documents in docs/design directory or not applicable
[NA] Updated user-facing documentation in docs directory or not applicable
[NA] Ran tests (e.g. make test) or not applicable
[x] Updated changelog or not applicable

michaelsauter commented 1 year ago

LGTM. I would add a note to the changelog as this is a user-facing change. It fixes bug #713.

henrjk commented 1 year ago

LGTM. I would add a note to the changelog as this is a user-facing change. It fixes bug #713.

Makes sense will do that soon.

michaelsauter commented 1 year ago

Hmm, the Go task tests fail in the sonar step. Do you have an idea if / how that could be related?

michaelsauter commented 1 year ago

Actually, https://github.com/opendevstack/ods-pipeline/actions/runs/5584494350 failed as well, also in regards to SQ, but for different tasks. Maybe there is a general issue I need to look into.

henrjk commented 1 year ago

Actually, https://github.com/opendevstack/ods-pipeline/actions/runs/5584494350 failed as well, also in regards to SQ, but for different tasks. Maybe there is a general issue I need to look into.

:-) I was starting to look at it. But haven't found an issue. There should be no impact on the go tasks though in this PR I'd say.